From 488e1b59feb4314b034636990bcc4e220e61f0ce Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 29 Sep 2022 18:08:16 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../lint/redundant_cop_disable_directive.yml | 114 +++++++++++++++--- .../components/jobs/failed_jobs_app.vue | 4 +- .../components/jobs/failed_jobs_table.vue | 4 +- .../pipelines/components/jobs/jobs_app.vue | 4 +- .../jobs_shared/action_component.vue | 4 +- .../pipeline_mini_graph/pipeline_stage.vue | 4 +- .../components/pipelines_list/pipelines.vue | 12 +- .../pipelines_manual_actions.vue | 4 +- .../tokens/pipeline_branch_name_token.vue | 4 +- .../tokens/pipeline_tag_name_token.vue | 4 +- .../tokens/pipeline_trigger_author_token.vue | 4 +- .../pipelines/mixins/pipelines_mixin.js | 4 +- .../pipelines/pipeline_details_bundle.js | 16 +-- .../pipelines/stores/test_reports/actions.js | 4 +- .../stores/test_reports/mutations.js | 4 +- app/assets/stylesheets/framework/tables.scss | 16 --- .../stylesheets/page_bundles/milestone.scss | 33 ----- app/helpers/milestones_helper.rb | 26 ++++ app/models/merge_request.rb | 4 + app/services/projects/import_service.rb | 6 +- app/views/profiles/show.html.haml | 31 +++-- .../shared/milestones/_issuables.html.haml | 28 ++--- config/application.rb | 1 + doc/administration/auth/smartcard.md | 2 +- doc/administration/reply_by_email.md | 2 +- doc/api/index.md | 2 +- doc/api/oauth2.md | 14 +-- doc/api/scim.md | 8 +- doc/ci/secrets/index.md | 2 +- doc/ci/variables/predefined_variables.md | 4 +- doc/development/polling.md | 2 +- doc/integration/ding_talk.md | 22 ++-- doc/integration/oauth2_generic.md | 53 ++++---- .../settings/user_and_ip_rate_limits.md | 2 +- .../container_scanning/index.md | 2 +- .../dependency_scanning/index.md | 2 +- doc/user/application_security/sast/index.md | 2 +- .../secret_detection/index.md | 2 +- doc/user/clusters/agent/install/index.md | 2 +- doc/user/group/saml_sso/scim_setup.md | 2 +- doc/user/project/pages/introduction.md | 2 +- doc/user/project/releases/index.md | 2 +- .../repository/x509_signed_commits/index.md | 2 +- lib/gitlab/ci/templates/Maven.gitlab-ci.yml | 47 +++++--- .../1_manage/login/log_in_with_2fa_spec.rb | 20 ++- .../projects/pipelines/pipelines_spec.rb | 4 +- .../components/jobs/failed_jobs_app_spec.js | 6 +- .../components/jobs/failed_jobs_table_spec.js | 4 +- .../components/jobs/jobs_app_spec.js | 6 +- .../pipelines/pipelines_actions_spec.js | 4 +- spec/frontend/pipelines/pipelines_spec.js | 9 +- .../test_reports/stores/actions_spec.js | 4 +- .../test_reports/stores/mutations_spec.js | 4 +- spec/helpers/milestones_helper_spec.rb | 41 +++++++ spec/models/merge_request_spec.rb | 10 ++ spec/services/projects/import_service_spec.rb | 9 ++ 56 files changed, 394 insertions(+), 240 deletions(-) create mode 100644 app/helpers/milestones_helper.rb create mode 100644 spec/helpers/milestones_helper_spec.rb diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index e4925aa2cfd..7668025601c 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -1,18 +1,22 @@ --- # Cop supports --auto-correct. Lint/RedundantCopDisableDirective: - # This cop can only be enabled after enabling all cops which are currently - # disabled. Otherwise we'll see RuboCop complaining depending on - # REVEAL_RUBOCOP_TODO environment variable. - Enabled: false + Details: grace period Exclude: + - 'app/controllers/concerns/enforces_two_factor_authentication.rb' + - 'app/controllers/concerns/web_hooks/hook_log_actions.rb' + - 'app/controllers/groups/autocomplete_sources_controller.rb' + - 'app/controllers/groups/labels_controller.rb' + - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb' - 'app/finders/autocomplete/move_to_project_finder.rb' - 'app/finders/autocomplete/routes_finder.rb' - 'app/finders/autocomplete/users_finder.rb' - 'app/finders/ci/daily_build_group_report_results_finder.rb' + - 'app/finders/ci/runner_jobs_finder.rb' - 'app/finders/groups_finder.rb' - 'app/finders/users_finder.rb' + - 'app/graphql/gitlab_schema.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - 'app/graphql/resolvers/project_milestones_resolver.rb' - 'app/graphql/types/base_enum.rb' @@ -20,13 +24,17 @@ Lint/RedundantCopDisableDirective: - 'app/graphql/types/packages/helm/dependency_type.rb' - 'app/graphql/types/projects/service_type_enum.rb' - 'app/helpers/diff_helper.rb' + - 'app/helpers/lazy_image_tag_helper.rb' - 'app/helpers/search_helper.rb' + - 'app/models/clusters/cluster.rb' - 'app/models/concerns/cascading_namespace_setting_attribute.rb' - 'app/models/concerns/from_except.rb' - 'app/models/concerns/from_intersect.rb' - 'app/models/concerns/from_union.rb' + - 'app/models/project_statistics.rb' - 'app/models/user.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' - 'app/serializers/diffs_entity.rb' - 'app/serializers/fork_namespace_entity.rb' - 'app/services/ci/job_artifacts/destroy_batch_service.rb' @@ -35,25 +43,35 @@ Lint/RedundantCopDisableDirective: - 'app/services/database/consistency_check_service.rb' - 'app/services/issues/export_csv_service.rb' - 'app/services/labels/transfer_service.rb' + - 'app/services/members/create_service.rb' + - 'app/services/members/creator_service.rb' + - 'app/services/members/projects/creator_service.rb' + - 'app/services/members/standard_member_builder.rb' - 'app/services/projects/auto_devops/disable_service.rb' - 'app/services/projects/open_issues_count_service.rb' - 'app/services/spam/spam_action_service.rb' - 'app/services/users/migrate_to_ghost_user_service.rb' - - 'app/services/web_hooks/destroy_service.rb' + - 'app/services/web_hook_service.rb' + - 'app/uploaders/object_storage/cdn/google_ip_cache.rb' - 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb' + - 'app/workers/build_hooks_worker.rb' - 'app/workers/bulk_imports/entity_worker.rb' - - 'app/workers/container_expiration_policy_worker.rb' + - 'app/workers/ci/track_failed_build_worker.rb' + - 'app/workers/container_registry/migration/enqueuer_worker.rb' - 'app/workers/create_note_diff_file_worker.rb' - 'app/workers/import_issues_csv_worker.rb' - 'app/workers/incident_management/process_alert_worker_v2.rb' - 'app/workers/merge_worker.rb' - 'app/workers/remove_unaccepted_member_invites_worker.rb' - 'config/initializers/warden.rb' - - 'config/initializers/wikicloth_redos_patch.rb' + - 'config/initializers/wikicloth_ruby_3_patch.rb' - 'config/routes/api.rb' - 'db/migrate/20210303193544_add_concurrent_fields_to_bulk_imports_trackers.rb' - 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb' - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' + - 'db/migrate/20220316022505_create_namespace_details.rb' + - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' + - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'db/post_migrate/20210610042700_remove_clusters_applications_fluentd_table.rb' - 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb' - 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb' @@ -62,8 +80,12 @@ Lint/RedundantCopDisableDirective: - 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' + - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' + - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' + - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' + - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/finders/geo/file_registry_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' - 'ee/app/finders/geo/registry_finder.rb' @@ -72,13 +94,16 @@ Lint/RedundantCopDisableDirective: - 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb' - 'ee/app/graphql/types/scan_type.rb' + - 'ee/app/graphql/types/vulnerability_request_type.rb' - 'ee/app/helpers/ee/boards_helper.rb' - - 'ee/app/helpers/ee/namespaces_helper.rb' - 'ee/app/helpers/projects/on_demand_scans_helper.rb' + - 'ee/app/models/dast/branch.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/event_log.rb' + - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' + - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/search_service.rb' - 'ee/app/services/ee/users/migrate_to_ghost_user_service.rb' - 'ee/app/services/geo/repository_base_sync_service.rb' @@ -92,20 +117,30 @@ Lint/RedundantCopDisableDirective: - 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb' - 'ee/lib/analytics/merge_request_metrics_calculator.rb' - 'ee/lib/api/audit_events.rb' + - 'ee/lib/api/scim.rb' - 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb' - - 'ee/lib/ee/api/settings.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' + - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' + - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb' + - 'ee/lib/gitlab/elastic/bool_expr.rb' + - 'ee/lib/gitlab/spdx/license.rb' + - 'ee/lib/gitlab/status_page/storage/object.rb' + - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - 'ee/spec/helpers/ee/releases_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' - 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - 'lib/api/api.rb' - 'lib/api/ci/variables.rb' - - 'lib/api/entities/environment.rb' - 'lib/api/entities/issuable_time_stats.rb' - 'lib/api/helpers.rb' - 'lib/bulk_imports/common/transformers/user_reference_transformer.rb' @@ -115,24 +150,32 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb' - 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb' + - 'lib/gitlab/application_context.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' + - 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' + - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' + - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/bitbucket_import/importer.rb' + - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/cache/request_cache.rb' - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' + - 'lib/gitlab/ci/pipeline/chain/command.rb' - 'lib/gitlab/ci/pipeline/duration.rb' - 'lib/gitlab/ci/reports/accessibility_reports.rb' - - 'lib/gitlab/ci/reports/test_reports.rb' + - 'lib/gitlab/ci/reports/test_report.rb' - 'lib/gitlab/ci/reports/test_reports_comparer.rb' - 'lib/gitlab/ci/reports/test_suite.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' + - 'lib/gitlab/cleanup/personal_access_tokens.rb' - 'lib/gitlab/composer/cache.rb' - 'lib/gitlab/database/consistency_checker.rb' - 'lib/gitlab/database/migration.rb' + - 'lib/gitlab/database/migrations/observation.rb' - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/file_collection/merge_request_diff_batch.rb' @@ -140,52 +183,95 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/encrypted_ldap_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' + - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/patches/collection.rb' - 'lib/gitlab/github_import/user_finder.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' + - 'lib/gitlab/health_checks/metric.rb' + - 'lib/gitlab/health_checks/probes/status.rb' + - 'lib/gitlab/health_checks/result.rb' - 'lib/gitlab/legacy_github_import/user_formatter.rb' + - 'lib/gitlab/middleware/release_env.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/pagination/keyset/pager.rb' - 'lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb' - 'lib/gitlab/profiler.rb' - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/redis/hll.rb' + - 'lib/gitlab/search/sort_options.rb' - 'lib/gitlab/slash_commands/issue_search.rb' + - 'lib/gitlab/slash_commands/result.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_queries.rb' - 'lib/gitlab/utils/usage_data.rb' + - 'lib/gitlab/x509/signature.rb' - 'lib/tasks/gitlab/cleanup.rake' + - 'qa/tasks/ci.rake' + - 'scripts/lib/glfm/render_static_html.rb' - 'scripts/security-harness' - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' + - 'spec/components/previews/pajamas/banner_component_preview.rb' + - 'spec/fixtures/packages/rubygems/package.gemspec' - 'spec/frontend/fixtures/merge_requests.rb' + - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/resolvers/base_resolver_spec.rb' - 'spec/helpers/releases_helper_spec.rb' + - 'spec/initializers/memory_watchdog_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_issue_work_item_type_batching_strategy_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' + - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' + - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' + - 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb' + - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/git/tree_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' + - 'spec/lib/gitlab/rack_attack/request_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' + - 'spec/lib/initializer_connections_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' + - 'spec/migrations/20220725150127_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' + - 'spec/migrations/reschedule_backfill_imported_issue_search_data_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/namespace/package_setting_spec.rb' - 'spec/models/namespace_spec.rb' + - 'spec/models/project_feature_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' - 'spec/requests/api/alert_management_alerts_spec.rb' + - 'spec/requests/api/graphql/ci/config_spec.rb' - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/services/alert_management/metric_images/upload_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/services/projects/update_statistics_service_spec.rb' + - 'spec/services/spam/spam_verdict_service_spec.rb' + - 'spec/services/topics/merge_service_spec.rb' + - 'spec/support/forgery_protection.rb' - 'spec/support/helpers/snowplow_helpers.rb' - 'spec/support/helpers/wait_for_requests.rb' + - 'spec/support/shared_examples/lib/gitlab/local_and_remote_storage_migration_shared_examples.rb' - 'spec/support/shared_examples/models/boards/listable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb' - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' + - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - 'tooling/danger/product_intelligence.rb' - 'tooling/lib/tooling/helm3_client.rb' diff --git a/app/assets/javascripts/pipelines/components/jobs/failed_jobs_app.vue b/app/assets/javascripts/pipelines/components/jobs/failed_jobs_app.vue index 9e886fd7a48..605d40eddee 100644 --- a/app/assets/javascripts/pipelines/components/jobs/failed_jobs_app.vue +++ b/app/assets/javascripts/pipelines/components/jobs/failed_jobs_app.vue @@ -1,7 +1,7 @@