Merge branch 'fix/remove-broken-inline-runner-desc-edit' into 'master'
Remove broken inline runner description edit form This remove inline form for editing runnner's description. It is broken because of missing partial / incorrect response and it also does not make much sense, since we have under 'Edit' button a form that makes it possible to edit more than just a description. See merge request !4095
This commit is contained in:
commit
48c80fdf43
2 changed files with 2 additions and 38 deletions
|
@ -1,34 +1,6 @@
|
||||||
# This is a manifest file that'll be compiled into application.js, which will include all the files
|
|
||||||
# listed below.
|
|
||||||
#
|
|
||||||
# Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
|
|
||||||
# or vendor/assets/javascripts of plugins, if any, can be referenced here using a relative path.
|
|
||||||
#
|
|
||||||
# It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
|
|
||||||
# the compiled file.
|
|
||||||
#
|
|
||||||
# WARNING: THE FIRST BLANK LINE MARKS THE END OF WHAT'S TO BE PROCESSED, ANY BLANK LINE SHOULD
|
|
||||||
# GO AFTER THE REQUIRES BELOW.
|
|
||||||
#
|
|
||||||
#= require pager
|
#= require pager
|
||||||
#= require jquery_nested_form
|
#= require jquery_nested_form
|
||||||
#= require_tree .
|
#= require_tree .
|
||||||
#
|
|
||||||
$(document).on 'click', '.edit-runner-link', (event) ->
|
|
||||||
event.preventDefault()
|
|
||||||
|
|
||||||
descr = $(this).closest('.runner-description').first()
|
|
||||||
descr.addClass('hide')
|
|
||||||
form = descr.next('.runner-description-form')
|
|
||||||
descrInput = form.find('input.description')
|
|
||||||
originalValue = descrInput.val()
|
|
||||||
form.removeClass('hide')
|
|
||||||
form.find('.cancel').on 'click', (event) ->
|
|
||||||
event.preventDefault()
|
|
||||||
|
|
||||||
form.addClass('hide')
|
|
||||||
descrInput.val(originalValue)
|
|
||||||
descr.removeClass('hide')
|
|
||||||
|
|
||||||
$(document).on 'click', '.assign-all-runner', ->
|
$(document).on 'click', '.assign-all-runner', ->
|
||||||
$(this).replaceWith('<i class="fa fa-refresh fa-spin"></i> Assign in progress..')
|
$(this).replaceWith('<i class="fa fa-refresh fa-spin"></i> Assign in progress..')
|
||||||
|
|
|
@ -11,18 +11,10 @@
|
||||||
= link_to admin_runner_path(runner) do
|
= link_to admin_runner_path(runner) do
|
||||||
= runner.short_sha
|
= runner.short_sha
|
||||||
%td
|
%td
|
||||||
.runner-description
|
|
||||||
= runner.description
|
= runner.description
|
||||||
%span (#{link_to 'edit', '#', class: 'edit-runner-link'})
|
|
||||||
.runner-description-form.hide
|
|
||||||
= form_for [:admin, runner], remote: true, html: { class: 'form-inline' } do |f|
|
|
||||||
.form-group
|
|
||||||
= f.text_field :description, class: 'form-control'
|
|
||||||
= f.submit 'Save', class: 'btn'
|
|
||||||
%span (#{link_to 'cancel', '#', class: 'cancel'})
|
|
||||||
%td
|
%td
|
||||||
- if runner.shared?
|
- if runner.shared?
|
||||||
\-
|
n/a
|
||||||
- else
|
- else
|
||||||
= runner.projects.count(:all)
|
= runner.projects.count(:all)
|
||||||
%td
|
%td
|
||||||
|
|
Loading…
Reference in a new issue