From 4938925517ffb73a07fbf55972ea415bd90ea342 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 4 Nov 2022 15:07:23 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .eslintignore | 2 + .gitlab/ci/rules.gitlab-ci.yml | 1 + .rubocop_todo/layout/line_length.yml | 1 - .rubocop_todo/rspec/context_wording.yml | 2 - .rubocop_todo/rspec/empty_line_after_hook.yml | 1 - GITLAB_METRICS_EXPORTER_VERSION | 2 +- .../show/components/fields/description.vue | 2 +- .../components/list_page/registry_header.vue | 9 +- .../shared/wikis/components/wiki_form.vue | 2 +- .../components/markdown/markdown_editor.vue | 26 +- .../components/work_item_description.vue | 22 +- .../components/work_item_detail.vue | 72 +- .../components/work_item_labels.vue | 22 +- .../graphql/work_item.fragment.graphql | 1 + .../graphql/work_item_by_iid.query.graphql | 23 + .../work_items/pages/create_work_item.vue | 46 +- .../work_items/pages/work_item_root.vue | 8 +- app/assets/javascripts/work_items/utils.js | 6 + .../jira_connect/application_controller.rb | 27 + .../cors_preflight_checks_controller.rb | 16 + .../oauth_application_ids_controller.rb | 6 +- .../jira_connect/subscriptions_controller.rb | 1 + .../projects/work_items_controller.rb | 1 + app/models/project.rb | 2 +- app/services/ci/create_pipeline_service.rb | 1 + config/application.rb | 15 +- config/open_api.yml | 2 + config/routes.rb | 5 +- .../14-7-deprecate-merged_by-api-field.yml | 6 +- ...x_members_on_id_where_namespace_id_null.rb | 15 + ...21103150250_migrate_sidekiq_queued_jobs.rb | 77 +++ ...or_vulnerability_reads_container_images.rb | 21 + db/schema_migrations/20221103084213 | 1 + db/schema_migrations/20221103150250 | 1 + db/schema_migrations/20221104100203 | 1 + db/structure.sql | 2 - .../packages/container_registry.md | 3 +- doc/administration/pages/index.md | 1 + doc/api/openapi/openapi.yaml | 642 +++++++++++++++++- doc/api/openapi/v4/access_requests.yaml | 381 ----------- doc/api/openapi/v4/access_tokens.yaml | 170 ----- doc/api/openapi/v4/metadata.yaml | 43 -- doc/api/openapi/v4/version.yaml | 28 - doc/update/deprecations.md | 6 +- doc/user/discussions/index.md | 9 +- doc/user/profile/notifications.md | 22 +- doc/user/project/members/index.md | 9 +- doc/user/project/merge_requests/index.md | 22 + lib/api/api.rb | 2 +- lib/api/ci/resource_groups.rb | 45 +- lib/api/entities/ci/job_basic.rb | 20 +- lib/api/entities/ci/resource_group.rb | 6 +- lib/gitlab/ci/config/external/file/base.rb | 65 +- lib/gitlab/ci/config/external/mapper.rb | 5 + lib/gitlab/ci/pipeline/chain/populate.rb | 17 - .../ci/pipeline/chain/populate_metadata.rb | 42 ++ lib/gitlab/email/common.rb | 59 ++ .../email/handler/create_issue_handler.rb | 2 +- .../email/handler/unsubscribe_handler.rb | 4 +- lib/gitlab/incoming_email.rb | 40 +- lib/gitlab/service_desk_email.rb | 18 +- lib/gitlab/sidekiq_migrate_jobs.rb | 3 +- scripts/rspec_helpers.sh | 7 - spec/features/issues/user_edits_issue_spec.rb | 29 + .../components/fields/description_spec.js | 2 +- .../list_page/registry_header_spec.js | 6 + .../shared/wikis/components/wiki_form_spec.js | 2 +- .../markdown/markdown_editor_spec.js | 29 +- .../components/work_item_description_spec.js | 28 +- .../components/work_item_detail_modal_spec.js | 1 + .../components/work_item_detail_spec.js | 51 +- .../components/work_item_labels_spec.js | 25 + spec/frontend/work_items/mock_data.js | 18 + .../work_items/pages/create_work_item_spec.js | 39 +- .../work_items/pages/work_item_root_spec.js | 11 +- .../pipeline/chain/populate_metadata_spec.rb | 136 ++++ .../gitlab/ci/pipeline/chain/populate_spec.rb | 62 -- .../email/handler/unsubscribe_handler_spec.rb | 10 +- spec/lib/gitlab/email/handler_spec.rb | 2 +- spec/lib/gitlab/incoming_email_spec.rb | 99 +-- spec/lib/gitlab/service_desk_email_spec.rb | 40 +- ...150250_migrate_sidekiq_queued_jobs_spec.rb | 90 +++ .../cors_preflight_checks_controller_spec.rb | 66 ++ .../oauth_application_ids_controller_spec.rb | 34 +- .../subscriptions_controller_spec.rb | 70 +- spec/requests/oauth/tokens_controller_spec.rb | 7 +- spec/spec_helper.rb | 1 + .../lib/email/email_shared_examples.rb | 140 ++++ 88 files changed, 1989 insertions(+), 1128 deletions(-) create mode 100644 app/assets/javascripts/work_items/graphql/work_item_by_iid.query.graphql create mode 100644 app/assets/javascripts/work_items/utils.js create mode 100644 app/controllers/jira_connect/cors_preflight_checks_controller.rb create mode 100644 db/post_migrate/20221103084213_remove_tmp_index_members_on_id_where_namespace_id_null.rb create mode 100644 db/post_migrate/20221103150250_migrate_sidekiq_queued_jobs.rb create mode 100644 db/post_migrate/20221104100203_recreate_async_trigram_index_for_vulnerability_reads_container_images.rb create mode 100644 db/schema_migrations/20221103084213 create mode 100644 db/schema_migrations/20221103150250 create mode 100644 db/schema_migrations/20221104100203 delete mode 100644 doc/api/openapi/v4/access_requests.yaml delete mode 100644 doc/api/openapi/v4/access_tokens.yaml delete mode 100644 doc/api/openapi/v4/metadata.yaml delete mode 100644 doc/api/openapi/v4/version.yaml create mode 100644 lib/gitlab/ci/pipeline/chain/populate_metadata.rb create mode 100644 lib/gitlab/email/common.rb create mode 100644 spec/lib/gitlab/ci/pipeline/chain/populate_metadata_spec.rb create mode 100644 spec/migrations/20221103150250_migrate_sidekiq_queued_jobs_spec.rb create mode 100644 spec/requests/jira_connect/cors_preflight_checks_controller_spec.rb create mode 100644 spec/support/shared_examples/lib/email/email_shared_examples.rb diff --git a/.eslintignore b/.eslintignore index 1d069e19385..5428964b1ce 100644 --- a/.eslintignore +++ b/.eslintignore @@ -8,4 +8,6 @@ /vendor/ /sitespeed-result/ /fixtures/**/*.graphql +# Storybook build artifacts +/storybook/public spec/fixtures/**/*.graphql diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index c8b1b374b24..0581c5d27e6 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -897,6 +897,7 @@ rules: - !reference [".strict-ee-only-rules", rules] - !reference [".frontend:rules:default-frontend-jobs-as-if-foss", rules] + - <<: *if-merge-request-labels-run-all-jest - <<: *if-merge-request changes: *frontend-patterns-for-as-if-foss diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index ee095512645..3cdede96163 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -1817,7 +1817,6 @@ Layout/LineLength: - 'ee/spec/features/groups/scim_token_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - - 'ee/spec/features/groups/usage_quotas_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/invites_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index f5c9e9cc059..f54d3b38f7a 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -123,10 +123,8 @@ RSpec/ContextWording: - 'ee/spec/features/groups/push_rules_spec.rb' - 'ee/spec/features/groups/saml_enforcement_spec.rb' - 'ee/spec/features/groups/saml_providers_spec.rb' - - 'ee/spec/features/groups/seat_usage/seat_usage_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - - 'ee/spec/features/groups/usage_quotas_spec.rb' - 'ee/spec/features/groups_spec.rb' - 'ee/spec/features/ide/user_commits_changes_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' diff --git a/.rubocop_todo/rspec/empty_line_after_hook.yml b/.rubocop_todo/rspec/empty_line_after_hook.yml index 4b1c4299b20..125055044de 100644 --- a/.rubocop_todo/rspec/empty_line_after_hook.yml +++ b/.rubocop_todo/rspec/empty_line_after_hook.yml @@ -4,7 +4,6 @@ RSpec/EmptyLineAfterHook: Exclude: - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' - - 'ee/spec/features/groups/usage_quotas_spec.rb' - 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb' - 'ee/spec/features/profiles/usage_quotas_spec.rb' - 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb' diff --git a/GITLAB_METRICS_EXPORTER_VERSION b/GITLAB_METRICS_EXPORTER_VERSION index 19666f20264..e470d75e4bf 100644 --- a/GITLAB_METRICS_EXPORTER_VERSION +++ b/GITLAB_METRICS_EXPORTER_VERSION @@ -1 +1 @@ -1cbf6d9ce79fe9df99b545529f7b7d754baea080 +af0cd47633f6e0a5b8ac349a2584c01164af701a diff --git a/app/assets/javascripts/issues/show/components/fields/description.vue b/app/assets/javascripts/issues/show/components/fields/description.vue index dbe634e7295..180dea77003 100644 --- a/app/assets/javascripts/issues/show/components/fields/description.vue +++ b/app/assets/javascripts/issues/show/components/fields/description.vue @@ -67,7 +67,7 @@ export default { :quick-actions-docs-path="quickActionsDocsPath" :enable-autocomplete="enableAutocomplete" supports-quick-actions - init-on-autofocus + autofocus @input="$emit('input', $event)" @keydown.meta.enter="updateIssuable" @keydown.ctrl.enter="updateIssuable" diff --git a/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/registry_header.vue b/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/registry_header.vue index 19d35a135fd..ba8caabb40a 100644 --- a/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/registry_header.vue +++ b/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/registry_header.vue @@ -95,13 +95,8 @@ export default { -