add feature specs for discussion lock
This commit is contained in:
parent
360c147057
commit
4971b85a52
3 changed files with 156 additions and 1 deletions
|
@ -28,7 +28,7 @@
|
|||
.disabled-comment.text-center.prepend-top-default
|
||||
%span.issuable-note-warning
|
||||
This
|
||||
= issuable.class.to_s.titleize
|
||||
= issuable.class.to_s.titleize.underscore
|
||||
is locked. Only
|
||||
%b project members
|
||||
can comment.
|
||||
|
|
106
spec/features/issuables/discussion_lock_spec.rb
Normal file
106
spec/features/issuables/discussion_lock_spec.rb
Normal file
|
@ -0,0 +1,106 @@
|
|||
require 'spec_helper'
|
||||
|
||||
describe 'Discussion Lock', :js do
|
||||
let(:user) { create(:user) }
|
||||
let(:issue) { create(:issue, project: project, author: user) }
|
||||
let(:project) { create(:project, :public) }
|
||||
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
context 'when a user is a team member' do
|
||||
before do
|
||||
project.add_developer(user)
|
||||
end
|
||||
|
||||
context 'when the discussion is unlocked' do
|
||||
it 'the user can lock the issue' do
|
||||
visit project_issue_path(project, issue)
|
||||
|
||||
expect(find('.issuable-sidebar')).to have_content('Unlocked')
|
||||
|
||||
page.within('.issuable-sidebar') do
|
||||
find('.lock-edit').click
|
||||
click_button('Lock')
|
||||
end
|
||||
|
||||
expect(find('#notes')).to have_content('locked this issue')
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the discussion is locked' do
|
||||
before do
|
||||
issue.update_attribute(:discussion_locked, true)
|
||||
visit project_issue_path(project, issue)
|
||||
end
|
||||
|
||||
it 'the user can unlock the issue' do
|
||||
expect(find('.issuable-sidebar')).to have_content('Locked')
|
||||
|
||||
page.within('.issuable-sidebar') do
|
||||
find('.lock-edit').click
|
||||
click_button('Unlock')
|
||||
end
|
||||
|
||||
expect(find('#notes')).to have_content('unlocked this issue')
|
||||
expect(find('.issuable-sidebar')).to have_content('Unlocked')
|
||||
end
|
||||
|
||||
it 'the user can create a comment' do
|
||||
page.within('#notes .js-main-target-form') do
|
||||
fill_in 'note[note]', with: 'Some new comment'
|
||||
click_button 'Comment'
|
||||
end
|
||||
|
||||
wait_for_requests
|
||||
|
||||
expect(find('div#notes')).to have_content('Some new comment')
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when a user is not a team member' do
|
||||
context 'when the discussion is unlocked' do
|
||||
before do
|
||||
visit project_issue_path(project, issue)
|
||||
end
|
||||
|
||||
it 'the user can not lock the issue' do
|
||||
expect(find('.issuable-sidebar')).to have_content('Unlocked')
|
||||
expect(find('.issuable-sidebar')).not_to have_selector('.lock-edit')
|
||||
end
|
||||
|
||||
it 'the user can create a comment' do
|
||||
page.within('#notes .js-main-target-form') do
|
||||
fill_in 'note[note]', with: 'Some new comment'
|
||||
click_button 'Comment'
|
||||
end
|
||||
|
||||
wait_for_requests
|
||||
|
||||
expect(find('div#notes')).to have_content('Some new comment')
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the discussion is locked' do
|
||||
before do
|
||||
issue.update_attribute(:discussion_locked, true)
|
||||
visit project_issue_path(project, issue)
|
||||
end
|
||||
|
||||
it 'the user can not unlock the issue' do
|
||||
expect(find('.issuable-sidebar')).to have_content('Locked')
|
||||
expect(find('.issuable-sidebar')).not_to have_selector('.lock-edit')
|
||||
end
|
||||
|
||||
it 'the user can not create a comment' do
|
||||
page.within('#notes') do
|
||||
expect(page).not_to have_selector('js-main-target-form')
|
||||
expect(page.find('.disabled-comment')).
|
||||
to have_content('This issue is locked. Only project members can comment.')
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
49
spec/features/merge_requests/discussion_lock_spec.rb
Normal file
49
spec/features/merge_requests/discussion_lock_spec.rb
Normal file
|
@ -0,0 +1,49 @@
|
|||
require 'spec_helper'
|
||||
|
||||
describe 'Discussion Lock', :js do
|
||||
let(:user) { create(:user) }
|
||||
let(:merge_request) { create(:merge_request, source_project: project, author: user) }
|
||||
let(:project) { create(:project, :public, :repository) }
|
||||
|
||||
before do
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
context 'when the discussion is locked' do
|
||||
before do
|
||||
merge_request.update_attribute(:discussion_locked, true)
|
||||
end
|
||||
|
||||
context 'when a user is a team member' do
|
||||
before do
|
||||
project.add_developer(user)
|
||||
visit project_merge_request_path(project, merge_request)
|
||||
end
|
||||
|
||||
it 'the user can create a comment' do
|
||||
page.within('.issuable-discussion #notes .js-main-target-form') do
|
||||
fill_in 'note[note]', with: 'Some new comment'
|
||||
click_button 'Comment'
|
||||
end
|
||||
|
||||
wait_for_requests
|
||||
|
||||
expect(find('.issuable-discussion #notes')).to have_content('Some new comment')
|
||||
end
|
||||
end
|
||||
|
||||
context 'when a user is not a team member' do
|
||||
before do
|
||||
visit project_merge_request_path(project, merge_request)
|
||||
end
|
||||
|
||||
it 'the user can not create a comment' do
|
||||
page.within('.issuable-discussion #notes') do
|
||||
expect(page).not_to have_selector('js-main-target-form')
|
||||
expect(page.find('.disabled-comment')).
|
||||
to have_content('This merge request is locked. Only project members can comment.')
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
Loading…
Reference in a new issue