kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix project name label's for reference in project settings

Browse source
This commit is contained in:
Clement Ho 2017-01-25 16:04:02 -06:00
parent 73c54366e6
commit 49831b5374
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/projects/edit.html.haml
View file

@ -9,7 +9,7 @@
%fieldset.append-bottom-0
.row
.form-group.col-md-9
= f.label :name, class: 'label-light' do
= f.label :name, class: 'label-light', for: 'project_name_edit' do
Project name
= f.text_field :name, class: "form-control", id: "project_name_edit"

4
changelogs/unreleased/27259-label-for-references-the-wrong-associated-text-input.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Fix project name label's for reference in project settings
merge_request: 8795
author:

4
spec/features/projects/project_settings_spec.rb
View file

@ -37,7 +37,7 @@ describe 'Edit Project Settings', feature: true do
it 'shows errors for invalid project path/name' do
visit edit_namespace_project_path(project.namespace, project)
fill_in 'Project name', with: 'foo&bar'
fill_in 'project_name', with: 'foo&bar'
fill_in 'Path', with: 'foo&bar'
click_button 'Rename project'
@ -53,7 +53,7 @@ describe 'Edit Project Settings', feature: true do
it 'shows error for invalid project name' do
visit edit_namespace_project_path(project.namespace, project)
fill_in 'Project name', with: '🚀 foo bar ☁️'
fill_in 'project_name', with: '🚀 foo bar ☁️'
click_button 'Rename project'