Enable the StringReplacement cop.
Also fix one use of `gsub` that would be faster as `delete`. Use `tr` instead of `gsub` when you are replacing the same number of characters. Use `delete` instead of `gsub` when you are deleting characters.
This commit is contained in:
parent
4a47470feb
commit
4995302df6
|
@ -990,11 +990,12 @@ Performance/RedundantSortBy:
|
||||||
# string.
|
# string.
|
||||||
Performance/StartWith:
|
Performance/StartWith:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Use `tr` instead of `gsub` when you are replacing the same number of
|
# Use `tr` instead of `gsub` when you are replacing the same number of
|
||||||
# characters. Use `delete` instead of `gsub` when you are deleting
|
# characters. Use `delete` instead of `gsub` when you are deleting
|
||||||
# characters.
|
# characters.
|
||||||
Performance/StringReplacement:
|
Performance/StringReplacement:
|
||||||
Enabled: false
|
Enabled: true
|
||||||
|
|
||||||
# TODO: Enable TimesMap Cop.
|
# TODO: Enable TimesMap Cop.
|
||||||
# Checks for `.times.map` calls.
|
# Checks for `.times.map` calls.
|
||||||
|
|
|
@ -18,7 +18,7 @@ module Gitlab
|
||||||
@lines.each do |line|
|
@lines.each do |line|
|
||||||
next if filename?(line)
|
next if filename?(line)
|
||||||
|
|
||||||
full_line = line.gsub(/\n/, '')
|
full_line = line.delete("\n")
|
||||||
|
|
||||||
if line.match(/^@@ -/)
|
if line.match(/^@@ -/)
|
||||||
type = "match"
|
type = "match"
|
||||||
|
|
Loading…
Reference in New Issue