kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Enable the StringReplacement cop.

Browse source 
Also fix one use of `gsub` that would be faster as `delete`.

Use `tr` instead of `gsub` when you are replacing the same number of
characters. Use `delete` instead of `gsub` when you are deleting
characters.
This commit is contained in:
Connor Shea 2016-04-27 18:22:46 -06:00
parent 4a47470feb
commit 4995302df6
No known key found for this signature in database
GPG key ID: F4D9B1FC7DB73ED1
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.rubocop.yml
View file

@ -990,11 +990,12 @@ Performance/RedundantSortBy:
# string.
Performance/StartWith:
Enabled: false
# Use `tr` instead of `gsub` when you are replacing the same number of
# characters. Use `delete` instead of `gsub` when you are deleting
# characters.
Performance/StringReplacement:
Enabled: false
Enabled: true
# TODO: Enable TimesMap Cop.
# Checks for `.times.map` calls.

2
lib/gitlab/diff/parser.rb
View file

@ -18,7 +18,7 @@ module Gitlab
@lines.each do |line|
next if filename?(line)
full_line = line.gsub(/\n/, '')
full_line = line.delete("\n")
if line.match(/^@@ -/)
type = "match"