kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Changes after review

Browse source
This commit is contained in:
Filipa Lacerda 2017-01-26 20:03:45 +00:00
parent 4472779b7f
commit 4ab83117fb
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/ci/status/_badge_link.html.haml
View file

@ -6,6 +6,4 @@
= custom_icon(status.icon) = custom_icon(status.icon)
= status.text = status.text
- else - else
%span{ class: css_classes } = render "ci/status/badge", status: status
= custom_icon(status.icon)
= status.text

4
spec/views/projects/builds/show.html.haml_spec.rb
View file

@ -28,6 +28,10 @@ describe 'projects/builds/show', :view do
expect(rendered).to have_css('.ci-status.ci-success', text: 'passed') expect(rendered).to have_css('.ci-status.ci-success', text: 'passed')
end end
it 'does not render a link to the build' do
expect(rendered).not_to have_link('passed')
end
it 'shows build id' do it 'shows build id' do
expect(rendered).to have_css('.js-build-id', text: build.id) expect(rendered).to have_css('.js-build-id', text: build.id)
end end