From 4b4c254b2cfaca26c2c8e2bda70d45c13e3a6f97 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 24 May 2022 12:09:04 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITALY_SERVER_VERSION | 2 +- .../behaviors/markdown/render_math.js | 4 +- .../notes/components/note_body.vue | 114 ++++++++++-------- .../notes/components/note_header.vue | 1 + .../notes/components/noteable_note.vue | 3 +- app/assets/javascripts/notes/constants.js | 2 + .../filtered_search_bar/tokens/base_token.vue | 2 +- app/models/ci/build.rb | 4 + app/models/environment.rb | 12 +- app/services/environments/stop_service.rb | 6 +- app/views/admin/users/_head.html.haml | 2 +- app/views/groups/settings/_advanced.html.haml | 2 +- app/workers/all_queues.yml | 9 -- app/workers/build_success_worker.rb | 4 +- .../repository_remove_remote_worker.rb | 35 ------ .../env_stopped_on_stop_success.yml | 8 ++ config/sidekiq_queues.yml | 2 - db/docs/ci_builds_runner_session.yml | 4 +- doc/administration/index.md | 2 +- .../packages/container_registry.md | 2 +- doc/administration/pages/index.md | 5 +- .../reference_architectures/1k_users.md | 2 +- .../reference_architectures/index.md | 2 +- doc/api/environments.md | 21 ++-- doc/api/project_snippets.md | 4 +- doc/ci/pipelines/cicd_minutes.md | 8 ++ doc/ci/pipelines/merge_trains.md | 2 +- doc/development/contributing/verify/index.md | 2 +- doc/development/pipelines.md | 20 +-- doc/development/query_count_limits.md | 2 +- doc/development/rails_initializers.md | 2 +- doc/development/routing.md | 2 +- doc/development/secure_coding_guidelines.md | 2 +- doc/development/service_ping/index.md | 2 +- .../testing_guide/end_to_end/resources.md | 2 +- doc/install/installation.md | 2 +- doc/subscriptions/index.md | 6 +- doc/update/zero_downtime.md | 2 +- .../dependency_scanning/index.md | 4 +- doc/user/clusters/agent/install/index.md | 6 +- doc/user/profile/preferences.md | 2 +- lib/api/environments.rb | 6 +- qa/qa/page/project/settings/merge_request.rb | 2 +- .../issues/user_comments_on_issue_spec.rb | 2 +- spec/features/markdown/math_spec.rb | 20 +++ .../merge_request/user_posts_notes_spec.rb | 2 +- .../projects/environments/environment_spec.rb | 3 - .../notes/components/note_body_spec.js | 35 +++++- spec/models/environment_spec.rb | 24 +++- spec/models/remote_mirror_spec.rb | 2 - .../update_environment_service_spec.rb | 2 +- .../environments/auto_stop_service_spec.rb | 2 +- .../environments/stop_service_spec.rb | 27 ++++- spec/workers/build_success_worker_spec.rb | 29 ++++- .../environments/auto_stop_worker_spec.rb | 2 +- spec/workers/every_sidekiq_worker_spec.rb | 1 - .../repository_remove_remote_worker_spec.rb | 48 -------- 57 files changed, 301 insertions(+), 226 deletions(-) delete mode 100644 app/workers/repository_remove_remote_worker.rb create mode 100644 config/feature_flags/development/env_stopped_on_stop_success.yml delete mode 100644 spec/workers/repository_remove_remote_worker_spec.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index f1af25946ec..92f91a90aaa 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -94055b253d05bc04f533c977be892b0cd6f225ea +803b179a6834fbebcc7886083731bb0f4a67c796 diff --git a/app/assets/javascripts/behaviors/markdown/render_math.js b/app/assets/javascripts/behaviors/markdown/render_math.js index 12f47255bdf..e29c6e9b0ba 100644 --- a/app/assets/javascripts/behaviors/markdown/render_math.js +++ b/app/assets/javascripts/behaviors/markdown/render_math.js @@ -1,6 +1,7 @@ import { spriteIcon } from '~/lib/utils/common_utils'; import { differenceInMilliseconds } from '~/lib/utils/datetime_utility'; import { s__ } from '~/locale'; +import { unrestrictedPages } from './constants'; // Renders math using KaTeX in any element with the // `js-render-math` class @@ -48,6 +49,7 @@ class SafeMathRenderer { this.renderElement = this.renderElement.bind(this); this.render = this.render.bind(this); this.attachEvents = this.attachEvents.bind(this); + this.pageName = document.querySelector('body').dataset.page; } renderElement(chosenEl) { @@ -56,7 +58,7 @@ class SafeMathRenderer { } const el = chosenEl || this.queue.shift(); - const forceRender = Boolean(chosenEl); + const forceRender = Boolean(chosenEl) || unrestrictedPages.includes(this.pageName); const text = el.textContent; el.removeAttribute('style'); diff --git a/app/assets/javascripts/notes/components/note_body.vue b/app/assets/javascripts/notes/components/note_body.vue index 6c9bc4461c2..9d0dc98f4e6 100644 --- a/app/assets/javascripts/notes/components/note_body.vue +++ b/app/assets/javascripts/notes/components/note_body.vue @@ -8,6 +8,7 @@ import { __ } from '~/locale'; import '~/behaviors/markdown/render_gfm'; import Suggestions from '~/vue_shared/components/markdown/suggestions.vue'; import autosave from '../mixins/autosave'; +import { CONFIDENTIAL_CLASSES } from '../constants'; import noteAttachment from './note_attachment.vue'; import noteAwardsList from './note_awards_list.vue'; import noteEditedText from './note_edited_text.vue'; @@ -54,6 +55,11 @@ export default { required: false, default: '', }, + isConfidential: { + type: Boolean, + required: false, + default: false, + }, }, computed: { ...mapGetters(['getDiscussion', 'suggestionsCount', 'getSuggestionsFilePaths']), @@ -95,6 +101,12 @@ export default { return escape(suggestion); }, + confidentialContainerClasses() { + if (this.isConfidential && !this.isEditing) { + return CONFIDENTIAL_CLASSES; + } + return ''; + }, }, mounted() { this.renderGFM(); @@ -160,53 +172,61 @@ export default {