Merge branch '19493-fork-does-not-protect-default-branch' into 'master'

Make forking protect default branch on completion

Closes #19493

See merge request gitlab-org/gitlab-ce!16449
This commit is contained in:
Douwe Maan 2018-01-15 17:16:39 +00:00
commit 4b99bee096
3 changed files with 14 additions and 4 deletions

View file

@ -17,10 +17,7 @@ class RepositoryForkWorker
project.repository_storage_path, project.disk_path)
raise "Unable to fork project #{project_id} for repository #{source_disk_path} -> #{project.disk_path}" unless result
project.repository.after_import
raise "Project #{project_id} had an invalid repository after fork" unless project.valid_repo?
project.import_finish
project.after_import
end
private

View file

@ -0,0 +1,5 @@
---
title: Makes forking protect default branch on completion
merge_request:
author:
type: fixed

View file

@ -47,6 +47,14 @@ describe RepositoryForkWorker do
perform!
end
it 'protects the default branch' do
expect_fork_repository.and_return(true)
perform!
expect(fork_project.protected_branches.first.name).to eq(fork_project.default_branch)
end
it 'flushes various caches' do
expect_fork_repository.and_return(true)