From 4b9ace6c1fead1b44f173eaee0cfaa58f46a258a Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 2 Sep 2020 09:10:23 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITALY_SERVER_VERSION | 2 +- Gemfile | 2 +- Gemfile.lock | 4 +- .../diffs/components/settings_dropdown.vue | 137 +++++++++--------- .../javascripts/issue_show/components/app.vue | 22 ++- .../issue_show/components/incident_tabs.vue | 26 ++++ .../issue_show/components/pinned_links.vue | 2 +- app/assets/javascripts/issue_show/incident.js | 21 +++ .../issue_show/{index.js => issue.js} | 5 +- .../javascripts/pages/projects/issues/show.js | 13 +- .../stylesheets/pages/merge_requests.scss | 6 + app/finders/concerns/merged_at_filter.rb | 12 +- .../resolvers/merge_requests_resolver.rb | 4 + app/graphql/types/merge_request_sort_enum.rb | 11 ++ app/helpers/application_settings_helper.rb | 3 +- app/helpers/container_registry_helper.rb | 8 + app/helpers/issuables_helper.rb | 5 +- app/models/application_setting.rb | 3 + .../application_setting_implementation.rb | 3 +- app/models/atlassian/identity.rb | 26 ++++ app/models/merge_request.rb | 26 ++++ app/models/service.rb | 4 +- app/models/snippet.rb | 4 + app/models/user.rb | 1 + .../ci/parse_dotenv_artifact_service.rb | 2 +- .../gitlab/delete_tags_service.rb | 35 +++++ .../third_party/delete_tags_service.rb | 2 +- .../application_settings/_registry.html.haml | 6 + .../projects/merge_requests/show.html.haml | 2 +- app/views/shared/wikis/_form.html.haml | 2 +- app/views/users/show.html.haml | 8 +- ...8193-limit-delete-tags-service-runtime.yml | 5 + ...ircle-icons-with-gitlab-svg-error-icon.yml | 5 + ...-version-bump-apollo_upload_server-gem.yml | 5 + ...gitlab-ui-glbutton-in-app-assets-javas.yml | 5 + ...-merge-request-sort-options-to-graphql.yml | 5 + .../add-flash-spacing-on-merge-request.yml | 5 + .../dblessing-atlassian-integration.yml | 5 + changelogs/unreleased/fix-regexp-dotenv.yml | 5 + changelogs/unreleased/tr-incident-tabs.yml | 5 + ...egistry_expiration_policies_throttling.yml | 7 + ...service_timeout_to_application_settings.rb | 19 +++ ...00821194920_create_atlassian_identities.rb | 39 +++++ db/schema_migrations/20200710113437 | 1 + db/schema_migrations/20200821194920 | 1 + db/structure.sql | 37 +++++ .../graphql/reference/gitlab_schema.graphql | 80 ++++++++++ doc/api/graphql/reference/gitlab_schema.json | 113 +++++++++++++++ doc/user/packages/container_registry/index.md | 5 + lib/api/helpers.rb | 4 + lib/api/helpers/snippets_helpers.rb | 42 +++++- lib/api/project_snippets.rb | 6 +- lib/api/snippets.rb | 23 +-- lib/container_registry/client.rb | 11 ++ .../keyset/conditions/base_condition.rb | 2 +- .../graphql/pagination/keyset/order_info.rb | 17 ++- locale/gitlab.pot | 15 ++ qa/qa/support/json_formatter.rb | 20 ++- spec/factories/atlassian_identities.rb | 11 ++ spec/features/admin/admin_settings_spec.rb | 49 +++++++ spec/features/issues/incident_issue_spec.rb | 26 ++++ .../components/settings_dropdown_spec.js | 26 ++-- .../issue_show/components/app_spec.js | 95 +++++++++--- .../issue_show/components/description_spec.js | 9 +- .../components/incident_tabs_spec.js | 44 ++++++ spec/frontend/issue_show/index_spec.js | 19 --- spec/frontend/issue_show/issue_spec.js | 26 ++++ spec/frontend/issue_show/mock_data.js | 10 ++ .../resolvers/merge_requests_resolver_spec.rb | 27 ++++ .../types/merge_request_sort_enum_spec.rb | 15 ++ spec/graphql/types/project_type_spec.rb | 3 +- .../helpers/container_registry_helper_spec.rb | 27 ++++ spec/helpers/issuables_helper_spec.rb | 3 +- spec/lib/container_registry/client_spec.rb | 53 +++++++ spec/models/application_setting_spec.rb | 2 + spec/models/atlassian/identity_spec.rb | 34 +++++ spec/models/merge_request_spec.rb | 35 +++++ spec/models/service_spec.rb | 10 ++ spec/models/snippet_spec.rb | 22 +++ spec/models/user_spec.rb | 1 + .../design_management/upload_spec.rb | 32 +--- .../graphql/project/merge_requests_spec.rb | 44 ++++++ spec/requests/api/snippets_spec.rb | 108 +++++++++++--- .../ci/parse_dotenv_artifact_service_spec.rb | 11 +- .../delete_tags_service_spec.rb | 16 ++ .../gitlab/delete_tags_service_spec.rb | 51 ++++++- spec/support/helpers/graphql_helpers.rb | 33 +++++ .../requests/snippet_shared_examples.rb | 4 + 88 files changed, 1495 insertions(+), 245 deletions(-) create mode 100644 app/assets/javascripts/issue_show/components/incident_tabs.vue create mode 100644 app/assets/javascripts/issue_show/incident.js rename app/assets/javascripts/issue_show/{index.js => issue.js} (67%) create mode 100644 app/graphql/types/merge_request_sort_enum.rb create mode 100644 app/helpers/container_registry_helper.rb create mode 100644 app/models/atlassian/identity.rb create mode 100644 changelogs/unreleased/208193-limit-delete-tags-service-runtime.yml create mode 100644 changelogs/unreleased/225935-replace-fa-exclamation-circle-icons-with-gitlab-svg-error-icon.yml create mode 100644 changelogs/unreleased/228657-version-bump-apollo_upload_server-gem.yml create mode 100644 changelogs/unreleased/229320-migrate-bootstrap-button-to-gitlab-ui-glbutton-in-app-assets-javas.yml create mode 100644 changelogs/unreleased/239116-add-merge-request-sort-options-to-graphql.yml create mode 100644 changelogs/unreleased/add-flash-spacing-on-merge-request.yml create mode 100644 changelogs/unreleased/dblessing-atlassian-integration.yml create mode 100644 changelogs/unreleased/fix-regexp-dotenv.yml create mode 100644 changelogs/unreleased/tr-incident-tabs.yml create mode 100644 config/feature_flags/development/container_registry_expiration_policies_throttling.yml create mode 100644 db/migrate/20200710113437_add_container_registry_delete_tags_service_timeout_to_application_settings.rb create mode 100644 db/migrate/20200821194920_create_atlassian_identities.rb create mode 100644 db/schema_migrations/20200710113437 create mode 100644 db/schema_migrations/20200821194920 create mode 100644 spec/factories/atlassian_identities.rb create mode 100644 spec/features/issues/incident_issue_spec.rb create mode 100644 spec/frontend/issue_show/components/incident_tabs_spec.js delete mode 100644 spec/frontend/issue_show/index_spec.js create mode 100644 spec/frontend/issue_show/issue_spec.js create mode 100644 spec/graphql/types/merge_request_sort_enum_spec.rb create mode 100644 spec/helpers/container_registry_helper_spec.rb create mode 100644 spec/models/atlassian/identity_spec.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index efde50ac13a..0d9079f6165 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -15c2f3921c4729e9c4d7ce8592300decfcfdb2e6 +12dcff902c9a2178fa6f4992d9d562ad9b422dd2 diff --git a/Gemfile b/Gemfile index a9f9912969f..2495a5ca48a 100644 --- a/Gemfile +++ b/Gemfile @@ -93,7 +93,7 @@ gem 'graphql', '~> 1.10.5' # TODO: remove app/views/graphiql/rails/editors/show.html.erb when https://github.com/rmosolgo/graphiql-rails/pull/71 is released: # https://gitlab.com/gitlab-org/gitlab/issues/31747 gem 'graphiql-rails', '~> 1.4.10' -gem 'apollo_upload_server', '~> 2.0.0.beta3' +gem 'apollo_upload_server', '~> 2.0.2' gem 'graphql-docs', '~> 1.6.0', group: [:development, :test] # Disable strong_params so that Mash does not respond to :permitted? diff --git a/Gemfile.lock b/Gemfile.lock index 0f5cfcdc056..ae678d2321b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -73,7 +73,7 @@ GEM public_suffix (>= 2.0.2, < 5.0) aes_key_wrap (1.0.1) akismet (3.0.0) - apollo_upload_server (2.0.0.beta.3) + apollo_upload_server (2.0.2) graphql (>= 1.8) rails (>= 4.2) asana (0.10.0) @@ -1220,7 +1220,7 @@ DEPENDENCIES acts-as-taggable-on (~> 6.0) addressable (~> 2.7) akismet (~> 3.0) - apollo_upload_server (~> 2.0.0.beta3) + apollo_upload_server (~> 2.0.2) asana (= 0.10.0) asciidoctor (~> 2.0.10) asciidoctor-include-ext (~> 0.3.1) diff --git a/app/assets/javascripts/diffs/components/settings_dropdown.vue b/app/assets/javascripts/diffs/components/settings_dropdown.vue index 80b44f7bb13..78647065c8e 100644 --- a/app/assets/javascripts/diffs/components/settings_dropdown.vue +++ b/app/assets/javascripts/diffs/components/settings_dropdown.vue @@ -1,16 +1,24 @@ diff --git a/app/assets/javascripts/issue_show/components/app.vue b/app/assets/javascripts/issue_show/components/app.vue index 992d87a969f..1cc04003aa6 100644 --- a/app/assets/javascripts/issue_show/components/app.vue +++ b/app/assets/javascripts/issue_show/components/app.vue @@ -20,7 +20,6 @@ export default { components: { GlIcon, GlIntersectionObserver, - descriptionComponent, titleComponent, editedComponent, formComponent, @@ -152,6 +151,18 @@ export default { required: false, default: 0, }, + descriptionComponent: { + type: Object, + required: false, + default: () => { + return descriptionComponent; + }, + }, + showTitleBorder: { + type: Boolean, + required: false, + default: true, + }, }, data() { const store = new Store({ @@ -209,6 +220,11 @@ export default { isOpenStatus() { return this.issuableStatus === IssuableStatus.Open; }, + pinnedLinkClasses() { + return this.showTitleBorder + ? 'gl-border-b-1 gl-border-b-gray-100 gl-border-b-solid gl-mb-6' + : ''; + }, statusIcon() { return this.isOpenStatus ? 'issue-open-m' : 'mobile-issue-close'; }, @@ -447,9 +463,11 @@ export default { - +import { GlTab, GlTabs } from '@gitlab/ui'; +import DescriptionComponent from './description.vue'; + +export default { + components: { + GlTab, + GlTabs, + DescriptionComponent, + }, +}; + + + diff --git a/app/assets/javascripts/issue_show/components/pinned_links.vue b/app/assets/javascripts/issue_show/components/pinned_links.vue index a877aa2ac96..36375ca743b 100644 --- a/app/assets/javascripts/issue_show/components/pinned_links.vue +++ b/app/assets/javascripts/issue_show/components/pinned_links.vue @@ -45,7 +45,7 @@ export default {