Refactor dashboard todos inside dispatcher

This commit is contained in:
Clement Ho 2018-01-08 21:55:28 +00:00 committed by Jacob Schatz
parent 8a7bbe1ff3
commit 4c1e1ab1d7
4 changed files with 10 additions and 7 deletions

View File

@ -56,7 +56,6 @@ import GfmAutoComplete from './gfm_auto_complete';
import ShortcutsBlob from './shortcuts_blob';
import SigninTabsMemoizer from './signin_tabs_memoizer';
import Star from './star';
import Todos from './todos';
import TreeView from './tree';
import UsagePing from './usage_ping';
import UsernameValidator from './username_validator';
@ -111,6 +110,7 @@ import Activities from './activities';
}
const fail = () => Flash('Error loading dynamic module');
const callDefault = m => m.default();
path = page.split(':');
shortcut_handler = null;
@ -212,7 +212,7 @@ import Activities from './activities';
projectSelect();
break;
case 'dashboard:todos:index':
new Todos();
import('./pages/dashboard/todos/index').then(callDefault).catch(fail);
break;
case 'dashboard:projects:index':
case 'dashboard:projects:starred':
@ -542,7 +542,7 @@ import Activities from './activities';
new CILintEditor();
break;
case 'users:show':
import('./pages/users/show').then(m => m.default()).catch(fail);
import('./pages/users/show').then(callDefault).catch(fail);
break;
case 'admin:conversational_development_index:show':
new UserCallout();

View File

@ -0,0 +1,3 @@
import Todos from './todos';
export default () => new Todos();

View File

@ -1,7 +1,7 @@
/* eslint-disable class-methods-use-this, no-unneeded-ternary, quote-props */
import { visitUrl } from './lib/utils/url_utility';
import UsersSelect from './users_select';
import { isMetaClick } from './lib/utils/common_utils';
import { visitUrl } from '~/lib/utils/url_utility';
import UsersSelect from '~/users_select';
import { isMetaClick } from '~/lib/utils/common_utils';
export default class Todos {
constructor() {

View File

@ -1,5 +1,5 @@
import * as urlUtils from '~/lib/utils/url_utility';
import Todos from '~/todos';
import Todos from '~/pages/dashboard/todos/index/todos';
import '~/lib/utils/common_utils';
describe('Todos', () => {