kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Branch with a commit detection defaults to Gitaly

Browse source 
By default this was an OPT_IN RPC, and now graduates to OPT_OUT as the
acceptance testing was successful in:
https://gitlab.com/gitlab-org/gitaly/issues/1008

This follows the conventions of our [migration
process](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md)
This commit is contained in:
Zeger-Jan van de Weg 2018-04-11 09:13:02 +02:00
parent 863e1a7a05
commit 4d3f0998e0
No known key found for this signature in database
GPG key ID: 65F6A8D64A88ABAC
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
changelogs/unreleased/zj-branch-containing-sha-opt-out.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Detecting branchnames containing a commit uses Gitaly by default
merge_request:
author:
type: performance

3
lib/gitlab/git/repository.rb
View file

@ -1385,7 +1385,8 @@ module Gitlab
end
def branch_names_contains_sha(sha)
gitaly_migrate(:branch_names_contains_sha) do |is_enabled|
gitaly_migrate(:branch_names_contains_sha,
status: Gitlab::GitalyClient::MigrationStatus::OPT_OUT) do |is_enabled|
if is_enabled
gitaly_ref_client.branch_names_contains_sha(sha)
else