kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'remove-unnecessary-freeze-in-lib' into 'master' 

Avoid calling freeze on already frozen strings in lib

See merge request gitlab-org/gitlab-ce!32788
This commit is contained in:
Lin Jen-Shin 2019-09-10 08:11:44 +00:00
parent 4e9a93a38d 736b5908da
commit 4d542db508
18 changed files with 31 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/api/helpers.rb
View File

@ -5,10 +5,10 @@ module API
include Gitlab::Utils
include Helpers::Pagination
SUDO_HEADER = "HTTP_SUDO".freeze
GITLAB_SHARED_SECRET_HEADER = "Gitlab-Shared-Secret".freeze
SUDO_HEADER = "HTTP_SUDO"
GITLAB_SHARED_SECRET_HEADER = "Gitlab-Shared-Secret"
SUDO_PARAM = :sudo
API_USER_ENV = 'gitlab.api.user'.freeze
API_USER_ENV = 'gitlab.api.user'
def declared_params(options = {})
options = { include_parent_namespaces: false }.merge(options)

2
lib/api/helpers/runner.rb
View File

@ -3,7 +3,7 @@
module API
module Helpers
module Runner
JOB_TOKEN_HEADER = 'HTTP_JOB_TOKEN'.freeze
JOB_TOKEN_HEADER = 'HTTP_JOB_TOKEN'
JOB_TOKEN_PARAM = :token
def runner_registration_token_valid?

2
lib/backup/manager.rb
View File

@ -4,7 +4,7 @@ module Backup
class Manager
ARCHIVES_TO_BACKUP = %w[uploads builds artifacts pages lfs registry].freeze
FOLDERS_TO_BACKUP = %w[repositories db].freeze
FILE_NAME_SUFFIX = '_gitlab_backup.tar'.freeze
FILE_NAME_SUFFIX = '_gitlab_backup.tar'
attr_reader :progress

2
lib/banzai/filter/color_filter.rb
View File

@ -5,7 +5,7 @@ module Banzai
# HTML filter that renders `color` followed by a color "chip".
#
class ColorFilter < HTML::Pipeline::Filter
COLOR_CHIP_CLASS = 'gfm-color_chip'.freeze
COLOR_CHIP_CLASS = 'gfm-color_chip'
def call
doc.css('code').each do |node|

4
lib/banzai/filter/external_link_filter.rb
View File

@ -5,8 +5,8 @@ module Banzai
# HTML Filter to modify the attributes of external links
class ExternalLinkFilter < HTML::Pipeline::Filter
SCHEMES = ['http', 'https', nil].freeze
RTLO = "\u202E".freeze
ENCODED_RTLO = '%E2%80%AE'.freeze
RTLO = "\u202E"
ENCODED_RTLO = '%E2%80%AE'
def call
links.each do |node|

4
lib/banzai/filter/footnote_filter.rb
View File

@ -17,8 +17,8 @@ module Banzai
#
class FootnoteFilter < HTML::Pipeline::Filter
INTEGER_PATTERN = /\A\d+\z/.freeze
FOOTNOTE_ID_PREFIX = 'fn'.freeze
FOOTNOTE_LINK_ID_PREFIX = 'fnref'.freeze
FOOTNOTE_ID_PREFIX = 'fn'
FOOTNOTE_LINK_ID_PREFIX = 'fnref'
FOOTNOTE_LI_REFERENCE_PATTERN = /\A#{FOOTNOTE_ID_PREFIX}\d+\z/.freeze
FOOTNOTE_LINK_REFERENCE_PATTERN = /\A#{FOOTNOTE_LINK_ID_PREFIX}\d+\z/.freeze
FOOTNOTE_START_NUMBER = 1

8
lib/banzai/filter/math_filter.rb
View File

@ -11,14 +11,14 @@ module Banzai
#
class MathFilter < HTML::Pipeline::Filter
# Attribute indicating inline or display math.
STYLE_ATTRIBUTE = 'data-math-style'.freeze
STYLE_ATTRIBUTE = 'data-math-style'
# Class used for tagging elements that should be rendered
TAG_CLASS = 'js-render-math'.freeze
TAG_CLASS = 'js-render-math'
INLINE_CLASSES = "code math #{TAG_CLASS}".freeze
INLINE_CLASSES = "code math #{TAG_CLASS}"
DOLLAR_SIGN = '$'.freeze
DOLLAR_SIGN = '$'
def call
doc.css('code').each do |code|

2
lib/banzai/filter/suggestion_filter.rb
View File

@ -5,7 +5,7 @@ module Banzai
module Filter
class SuggestionFilter < HTML::Pipeline::Filter
# Class used for tagging elements that should be rendered
TAG_CLASS = 'js-render-suggestion'.freeze
TAG_CLASS = 'js-render-suggestion'
def call
return doc unless suggestions_filter_enabled?

4
lib/banzai/filter/syntax_highlight_filter.rb
View File

@ -10,8 +10,8 @@ module Banzai
class SyntaxHighlightFilter < HTML::Pipeline::Filter
include OutputSafety
PARAMS_DELIMITER = ':'.freeze
LANG_PARAMS_ATTR = 'data-lang-params'.freeze
PARAMS_DELIMITER = ':'
LANG_PARAMS_ATTR = 'data-lang-params'
def call
doc.search('pre:not([data-math-style]) > code').each do |node|

4
lib/banzai/issuable_extractor.rb
View File

@ -11,8 +11,8 @@ module Banzai
class IssuableExtractor
attr_reader :context
ISSUE_REFERENCE_TYPE = '@data-reference-type="issue"'.freeze
MERGE_REQUEST_REFERENCE_TYPE = '@data-reference-type="merge_request"'.freeze
ISSUE_REFERENCE_TYPE = '@data-reference-type="issue"'
MERGE_REQUEST_REFERENCE_TYPE = '@data-reference-type="merge_request"'
# context - An instance of Banzai::RenderContext.
def initialize(context)

4
lib/bitbucket/connection.rb
View File

@ -2,8 +2,8 @@
module Bitbucket
class Connection
DEFAULT_API_VERSION = '2.0'.freeze
DEFAULT_BASE_URI = 'https://api.bitbucket.org/'.freeze
DEFAULT_API_VERSION = '2.0'
DEFAULT_BASE_URI = 'https://api.bitbucket.org/'
DEFAULT_QUERY = {}.freeze
attr_reader :expires_at, :expires_in, :refresh_token, :token

4
lib/gitlab.rb
View File

@ -29,13 +29,13 @@ module Gitlab
if result.status.success?
result.stdout.chomp.freeze
else
"Unknown".freeze
"Unknown"
end
end
end
end
COM_URL = 'https://gitlab.com'.freeze
COM_URL = 'https://gitlab.com'
APP_DIRS_PATTERN = %r{^/?(app|config|ee|lib|spec|\(\w*\))}.freeze
SUBDOMAIN_REGEX = %r{\Ahttps://[a-z0-9]+\.gitlab\.com\z}.freeze
VERSION = File.read(root.join("VERSION")).strip.freeze

4
lib/google_api/cloud_platform/client.rb
View File

@ -8,9 +8,9 @@ require 'google/apis/cloudresourcemanager_v1'
module GoogleApi
module CloudPlatform
class Client < GoogleApi::Auth
SCOPE = 'https://www.googleapis.com/auth/cloud-platform'.freeze
SCOPE = 'https://www.googleapis.com/auth/cloud-platform'
LEAST_TOKEN_LIFE_TIME = 10.minutes
CLUSTER_MASTER_AUTH_USERNAME = 'admin'.freeze
CLUSTER_MASTER_AUTH_USERNAME = 'admin'
class << self
def session_key_for_token

2
lib/quality/test_level.rb
View File

@ -53,7 +53,7 @@ module Quality
end
def pattern(level)
@patterns[level] ||= "#{prefix}spec/{#{TEST_LEVEL_FOLDERS.fetch(level).join(',')}}{,/**/}*_spec.rb".freeze
@patterns[level] ||= "#{prefix}spec/{#{TEST_LEVEL_FOLDERS.fetch(level).join(',')}}{,/**/}*_spec.rb"
end
def regexp(level)

2
lib/system_check/app/init_script_up_to_date_check.rb
View File

@ -3,7 +3,7 @@
module SystemCheck
module App
class InitScriptUpToDateCheck < SystemCheck::BaseCheck
SCRIPT_PATH = '/etc/init.d/gitlab'.freeze
SCRIPT_PATH = '/etc/init.d/gitlab'
set_name 'Init script up-to-date?'
set_skip_reason 'skipped (omnibus-gitlab has no init script)'

2
lib/system_check/app/redis_version_check.rb
View File

@ -3,7 +3,7 @@
module SystemCheck
module App
class RedisVersionCheck < SystemCheck::BaseCheck
MIN_REDIS_VERSION = '2.8.0'.freeze
MIN_REDIS_VERSION = '2.8.0'
set_name "Redis version >= #{MIN_REDIS_VERSION}?"
def check?

4
lib/tasks/gitlab/graphql.rake
View File

@ -3,8 +3,8 @@
return if Rails.env.production?
namespace :gitlab do
OUTPUT_DIR = Rails.root.join("doc/api/graphql/reference").freeze
TEMPLATES_DIR = 'lib/gitlab/graphql/docs/templates/'.freeze
OUTPUT_DIR = Rails.root.join("doc/api/graphql/reference")
TEMPLATES_DIR = 'lib/gitlab/graphql/docs/templates/'
namespace :graphql do
desc 'GitLab | Generate GraphQL docs'

2
lib/tasks/gitlab/uploads/legacy.rake
View File

@ -11,7 +11,7 @@ namespace :gitlab do
include ::EachBatch
end
migration = 'LegacyUploadsMigrator'.freeze
migration = 'LegacyUploadsMigrator'
batch_size = 5000
delay_interval = 5.minutes.to_i