kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'docs/zj-reviewer-guidelines' into 'master'

Browse source 
Add a soft SLA for reviewers and maintainers

See merge request gitlab-org/gitlab-ce!25192
This commit is contained in:
Nick Thomas 2019-02-18 10:31:04 +00:00
commit 4e42168b09
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
doc/development/code_review.md
View file

@ -137,6 +137,14 @@ If a developer who happens to also be a maintainer was involved in a merge reque
as a domain expert and/or reviewer, it is recommended that they are not also picked
as the maintainer to ultimately approve and merge it.
Try to review in a timely manner; doing so allows everyone involved in the merge
request to iterate faster as the context is fresh in memory. Further, this
improves contributors' experiences significantly. Reviewers should aim to review
within two working days from the date they were assigned the merge request. If
you don't think you'll be able to review a merge request within that time, let
the author know as soon as possible. When the author of the merge request has not
heard anything after two days, a new reviewer should be assigned.
Maintainers should check before merging if the merge request is approved by the
required approvers.