From 2ba0118505ef52ff46ba3b0d6c457c87ffa7f97a Mon Sep 17 00:00:00 2001 From: Zeger-Jan van de Weg Date: Wed, 28 Mar 2018 11:15:49 +0200 Subject: [PATCH] Move ListCommitsByOid to OPT_OUT Acceptence testing was successfull in [#844](https://gitlab.com/gitlab-org/gitaly/issues/844) Part of gitlab-org/gitaly#670 --- changelogs/unreleased/zj-opt-out-list-commits-by-oid.yml | 5 +++++ lib/gitlab/git/commit.rb | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/zj-opt-out-list-commits-by-oid.yml diff --git a/changelogs/unreleased/zj-opt-out-list-commits-by-oid.yml b/changelogs/unreleased/zj-opt-out-list-commits-by-oid.yml new file mode 100644 index 00000000000..3871293ee04 --- /dev/null +++ b/changelogs/unreleased/zj-opt-out-list-commits-by-oid.yml @@ -0,0 +1,5 @@ +--- +title: ListCommitsByOid is executed by Gitaly by default +merge_request: +author: +type: performance diff --git a/lib/gitlab/git/commit.rb b/lib/gitlab/git/commit.rb index 93037ed8d90..0fb82441bf8 100644 --- a/lib/gitlab/git/commit.rb +++ b/lib/gitlab/git/commit.rb @@ -231,7 +231,8 @@ module Gitlab # relation to each other. The last 10 commits for a branch for example, # should go through .where def batch_by_oid(repo, oids) - repo.gitaly_migrate(:list_commits_by_oid) do |is_enabled| + repo.gitaly_migrate(:list_commits_by_oid, + status: Gitlab::GitalyClient::MigrationStatus::OPT_OUT) do |is_enabled| if is_enabled repo.gitaly_commit_client.list_commits_by_oid(oids) else