From 5051f6549732bead5d4df5cc576c6104c5afa6f3 Mon Sep 17 00:00:00 2001
From: syasonik <syasonik@gitlab.com>
Date: Tue, 29 Jan 2019 17:58:04 -0800
Subject: [PATCH] Refactor envs helper for clarity

---
 app/controllers/projects/environments_controller.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/controllers/projects/environments_controller.rb b/app/controllers/projects/environments_controller.rb
index 1a1b024d766..4e85de25c6b 100644
--- a/app/controllers/projects/environments_controller.rb
+++ b/app/controllers/projects/environments_controller.rb
@@ -182,11 +182,11 @@ class Projects::EnvironmentsController < Projects::ApplicationController
   end
 
   def serialize_environments(request, response, nested = false)
-    serializer = EnvironmentSerializer
+    EnvironmentSerializer
       .new(project: @project, current_user: @current_user)
+      .tap { |serializer| serializer.within_folders if nested }
       .with_pagination(request, response)
-    serializer = serializer.within_folders if nested
-    serializer.represent(@environments)
+      .represent(@environments)
   end
 
   def authorize_stop_environment!