From 50d66f5ece57dcfbe074d97703691a8d3c38f4ac Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 1 Apr 2021 12:08:56 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_manual_todo.yml | 4 - GITALY_SERVER_VERSION | 2 +- .../board_card_loading_skeleton.vue | 26 +++ .../boards/components/board_content.vue | 2 +- .../boards/components/board_new_issue.vue | 2 +- .../components/board_new_issue_deprecated.vue | 2 +- .../boards/graphql/issue.fragment.graphql | 4 + .../components/avatars/user_avatar.vue | 3 +- .../members_filtered_search_bar.vue | 3 +- .../components/table/members_table.vue | 3 +- .../components/table/members_table_cell.vue | 3 +- app/assets/javascripts/members/index.js | 10 +- app/assets/javascripts/members/store/state.js | 6 - .../infrastructure_registry/index/index.js | 3 + app/assets/stylesheets/framework/common.scss | 1 - .../stylesheets/page_bundles/boards.scss | 10 ++ app/assets/stylesheets/pages/commits.scss | 8 +- app/assets/stylesheets/pages/editor.scss | 2 +- app/assets/stylesheets/pages/groups.scss | 11 -- app/assets/stylesheets/pages/help.scss | 7 - app/assets/stylesheets/pages/issuable.scss | 2 +- app/assets/stylesheets/pages/projects.scss | 6 +- .../infrastructure_registry_controller.rb | 9 + .../experience_levels_controller.rb | 2 +- app/finders/git_refs_finder.rb | 12 +- app/helpers/projects_helper.rb | 4 + app/models/ci/processable.rb | 8 +- app/presenters/ci/build_runner_presenter.rb | 12 ++ ...merge_request_poll_cached_widget_entity.rb | 8 + .../merge_request_poll_widget_entity.rb | 6 +- .../application_settings/_realtime.html.haml | 11 +- .../_repository_check.html.haml | 33 ++-- .../sidebar/_project_packages_link.html.haml | 8 +- .../infrastructure_registry/index.html.haml | 10 ++ ...30-cablett-filter-epics-by-reaction-be.yml | 5 + ...on-git-activity-and-direct-user-to-sso.yml | 5 + ...rnalise-strings-in-_realtime-html-haml.yml | 5 + ...strings-in-_repository_check-html-haml.yml | 5 + ...s-savebang-legacy-github-import-module.yml | 5 + ...86-improve_award_emoji_filtering_query.yml | 5 + .../ref-finder-performance-improvement.yml | 5 + changelogs/unreleased/rename-create-issue.yml | 5 + .../infrastructure_registry_page.yml | 8 + ...quest_cached_merge_pipeline_serializer.yml | 8 + ...associations_jobs_request_api_endpoint.yml | 8 + config/routes/project.rb | 2 + ...add_enforced_git_check_to_saml_provider.rb | 13 ++ ...2716_add_composite_index_to_award_emoji.rb | 18 ++ ...emove_deprecated_index_from_award_emoji.rb | 19 ++ db/schema_migrations/20210312174321 | 1 + db/schema_migrations/20210329192716 | 1 + db/schema_migrations/20210331180118 | 1 + db/structure.sql | 7 +- doc/administration/nfs.md | 20 +++ doc/development/api_graphql_styleguide.md | 26 ++- doc/development/code_review.md | 4 +- doc/development/documentation/structure.md | 2 +- doc/development/snowplow.md | 2 + .../incident_management/incidents.md | 2 +- doc/user/discussions/index.md | 2 +- doc/user/group/saml_sso/index.md | 11 +- .../project/issues/confidential_issues.md | 2 +- doc/user/project/pages/introduction.md | 2 +- lib/gitlab/git_access.rb | 5 + lib/gitlab/tracking.rb | 4 +- lib/gitlab/tracking/standard_context.rb | 11 +- locale/gitlab.pot | 98 +++++++++-- scripts/gitaly-test-build | 2 + scripts/gitaly-test-spawn | 1 + scripts/gitaly_test.rb | 24 ++- spec/features/boards/new_issue_spec.rb | 6 +- spec/features/boards/sidebar_spec.rb | 40 +---- .../boards/sidebar_subscription_spec.rb | 54 ------ .../boards/sidebar_time_tracking_spec.rb | 52 ------ spec/features/groups/board_spec.rb | 2 +- spec/features/groups/navbar_spec.rb | 4 +- spec/features/projects/navbar_spec.rb | 4 +- spec/features/users/terms_spec.rb | 2 +- .../boards/board_new_issue_deprecated_spec.js | 16 +- .../boards/components/board_new_issue_spec.js | 6 +- .../components/avatars/user_avatar_spec.js | 16 +- .../members_filtered_search_bar_spec.js | 27 +-- .../filter_sort/sort_dropdown_spec.js | 4 +- .../table/members_table_cell_spec.js | 12 +- .../components/table/members_table_spec.js | 11 +- spec/frontend/members/index_spec.js | 27 --- .../context_payload_processor_spec.rb | 4 +- .../legacy_github_import/importer_spec.rb | 2 +- .../issue_formatter_spec.rb | 2 +- .../milestone_formatter_spec.rb | 2 +- .../pull_request_formatter_spec.rb | 2 +- .../gitlab/tracking/standard_context_spec.rb | 12 +- spec/lib/gitlab/tracking_spec.rb | 5 +- .../api/ci/runner/jobs_request_post_spec.rb | 30 ++++ ..._request_poll_cached_widget_entity_spec.rb | 45 +++++ .../merge_request_poll_widget_entity_spec.rb | 29 ++- .../helpers/navbar_structure_helper.rb | 12 +- spec/support/matchers/exceed_query_limit.rb | 5 + .../features/sidebar_shared_examples.rb | 165 ++++++++++++++++++ .../exceed_query_limit_helpers_spec.rb | 10 ++ 100 files changed, 833 insertions(+), 362 deletions(-) create mode 100644 app/assets/javascripts/boards/components/board_card_loading_skeleton.vue create mode 100644 app/assets/javascripts/pages/projects/packages/infrastructure_registry/index/index.js create mode 100644 app/controllers/projects/packages/infrastructure_registry_controller.rb create mode 100644 app/views/projects/packages/infrastructure_registry/index.html.haml create mode 100644 changelogs/unreleased/325630-cablett-filter-epics-by-reaction-be.yml create mode 100644 changelogs/unreleased/9152-check-sso-status-on-git-activity-and-direct-user-to-sso.yml create mode 100644 changelogs/unreleased/Externalise-strings-in-_realtime-html-haml.yml create mode 100644 changelogs/unreleased/Externalise-strings-in-_repository_check-html-haml.yml create mode 100644 changelogs/unreleased/issue-220040-fix-rails-savebang-legacy-github-import-module.yml create mode 100644 changelogs/unreleased/issue_322686-improve_award_emoji_filtering_query.yml create mode 100644 changelogs/unreleased/ref-finder-performance-improvement.yml create mode 100644 changelogs/unreleased/rename-create-issue.yml create mode 100644 config/feature_flags/development/infrastructure_registry_page.yml create mode 100644 config/feature_flags/development/merge_request_cached_merge_pipeline_serializer.yml create mode 100644 config/feature_flags/development/preload_associations_jobs_request_api_endpoint.yml create mode 100644 db/migrate/20210312174321_add_enforced_git_check_to_saml_provider.rb create mode 100644 db/migrate/20210329192716_add_composite_index_to_award_emoji.rb create mode 100644 db/migrate/20210331180118_remove_deprecated_index_from_award_emoji.rb create mode 100644 db/schema_migrations/20210312174321 create mode 100644 db/schema_migrations/20210329192716 create mode 100644 db/schema_migrations/20210331180118 delete mode 100644 spec/features/boards/sidebar_subscription_spec.rb delete mode 100644 spec/features/boards/sidebar_time_tracking_spec.rb create mode 100644 spec/support/shared_examples/features/sidebar_shared_examples.rb diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 5a1e5dc316a..2ca2a1d28ce 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -278,10 +278,6 @@ Rails/SaveBang: - 'spec/lib/gitlab/import_export/uploads_manager_spec.rb' - 'spec/lib/gitlab/import_export/uploads_saver_spec.rb' - 'spec/lib/gitlab/import_export/wiki_restorer_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb' - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index a8a3d86d5a3..0020837c7c6 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -c5786b09543e40acc6e05bd4d29f6d89106b8e8a +46db2b9e1da386cc081455eef16f5fa1a9fefa51 diff --git a/app/assets/javascripts/boards/components/board_card_loading_skeleton.vue b/app/assets/javascripts/boards/components/board_card_loading_skeleton.vue new file mode 100644 index 00000000000..15bff1226a6 --- /dev/null +++ b/app/assets/javascripts/boards/components/board_card_loading_skeleton.vue @@ -0,0 +1,26 @@ + + + diff --git a/app/assets/javascripts/boards/components/board_content.vue b/app/assets/javascripts/boards/components/board_content.vue index b30d766f15a..8423457ac07 100644 --- a/app/assets/javascripts/boards/components/board_content.vue +++ b/app/assets/javascripts/boards/components/board_content.vue @@ -127,7 +127,7 @@ export default { {{ __('Submit issue') }}{{ __('Create issue') }} { if ( diff --git a/app/assets/javascripts/members/components/table/members_table.vue b/app/assets/javascripts/members/components/table/members_table.vue index 9a3edff19ff..5db29951d94 100644 --- a/app/assets/javascripts/members/components/table/members_table.vue +++ b/app/assets/javascripts/members/components/table/members_table.vue @@ -31,8 +31,9 @@ export default { LdapOverrideConfirmationModal: () => import('ee_component/members/components/ldap/ldap_override_confirmation_modal.vue'), }, + inject: ['currentUserId'], computed: { - ...mapState(['members', 'tableFields', 'tableAttrs', 'currentUserId']), + ...mapState(['members', 'tableFields', 'tableAttrs']), filteredFields() { return FIELDS.filter( (field) => this.tableFields.includes(field.key) && this.showField(field), diff --git a/app/assets/javascripts/members/components/table/members_table_cell.vue b/app/assets/javascripts/members/components/table/members_table_cell.vue index 1f537740f94..3436bcab2fc 100644 --- a/app/assets/javascripts/members/components/table/members_table_cell.vue +++ b/app/assets/javascripts/members/components/table/members_table_cell.vue @@ -1,5 +1,4 @@