Fix #47796 "Web IDE autocomplete should be disabled in markdown files"

This commit is contained in:
Isaac Smith 2018-06-15 13:22:56 -05:00
parent 15ad1a9767
commit 5104098fab
3 changed files with 25 additions and 0 deletions

View File

@ -12,5 +12,6 @@ export const defaultEditorOptions = {
export default [
{
readOnly: model => !!model.file.file_lock,
quickSuggestions: model => !(model.language === 'markdown'),
},
];

View File

@ -0,0 +1,5 @@
---
title: Disabled Web IDE autocomplete suggestions for Markdown files.
merge_request:
author: Isaac Smith
type: fixed

View File

@ -263,4 +263,23 @@ describe('Multi-file editor library', () => {
expect(instance.isDiffEditorType).toBe(false);
});
});
it('sets quickSuggestions to false when language is markdown', () => {
instance.createInstance(holder);
spyOn(instance.instance, 'updateOptions').and.callThrough();
const model = instance.createModel({
...file(),
key: 'index.md',
path: 'index.md',
});
instance.attachModel(model);
expect(instance.instance.updateOptions).toHaveBeenCalledWith({
readOnly: false,
quickSuggestions: false,
});
});
});