From 5156a30440a66bb1cf91b0d4e89b52043f0a1d66 Mon Sep 17 00:00:00 2001
From: Fabio Papa <fabtheman@gmail.com>
Date: Sun, 16 Jun 2019 11:07:17 -0700
Subject: [PATCH] Add failing unit test specifying a maintainer creating a
 subgroup

---
 spec/services/groups/create_service_spec.rb          |  9 +++++++++
 .../policies/group_policy_shared_context.rb          | 12 ++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/spec/services/groups/create_service_spec.rb b/spec/services/groups/create_service_spec.rb
index c5ff6cdbacd..b4e6ddddfac 100644
--- a/spec/services/groups/create_service_spec.rb
+++ b/spec/services/groups/create_service_spec.rb
@@ -1,3 +1,4 @@
+# coding: utf-8
 # frozen_string_literal: true
 
 require 'spec_helper'
@@ -87,6 +88,14 @@ describe Groups::CreateService, '#execute' do
 
         it { is_expected.to be_persisted }
       end
+
+      context 'as maintainer' do
+        before do
+          group.add_maintainer(user)
+        end
+
+        it { is_expected.to be_persisted }
+      end
     end
   end
 
diff --git a/spec/support/shared_contexts/policies/group_policy_shared_context.rb b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
index 74389c4d82b..d596317462a 100644
--- a/spec/support/shared_contexts/policies/group_policy_shared_context.rb
+++ b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
@@ -23,6 +23,15 @@ RSpec.shared_context 'GroupPolicy context' do
       create_projects
       read_cluster create_cluster update_cluster admin_cluster add_cluster
     ]
+    [
+      :create_projects,
+      :read_cluster,
+      :create_cluster,
+      :update_cluster,
+      :admin_cluster,
+      :add_cluster,
+      (Gitlab::Database.postgresql? ? :create_subgroup : nil)
+    ].compact
   end
   let(:owner_permissions) do
     [
@@ -30,8 +39,7 @@ RSpec.shared_context 'GroupPolicy context' do
       :admin_namespace,
       :admin_group_member,
       :change_visibility_level,
-      :set_note_created_at,
-      (Gitlab::Database.postgresql? ? :create_subgroup : nil)
+      :set_note_created_at
     ].compact
   end