kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Resolve "Admin Settings: Cannot read property 'addEventListener' of null"

Browse source
This commit is contained in:
Martin Wortschack 2019-01-21 12:39:11 +00:00 committed by Phil Hughes
parent 466a77517b
commit 51a9c54923
4 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/assets/javascripts/pages/admin/application_settings/show/index.js Normal file
View file

@ -0,0 +1,3 @@
import initUserInternalRegexPlaceholder from '../../application_settings/account_and_limits';
document.addEventListener('DOMContentLoaded', initUserInternalRegexPlaceholder());

6
app/assets/javascripts/pages/admin/index.js
View file

@ -1,7 +1,3 @@
import initAdmin from './admin';
import initUserInternalRegexPlaceholder from './application_settings/account_and_limits';
document.addEventListener('DOMContentLoaded', () => {
initAdmin();
initUserInternalRegexPlaceholder();
});
document.addEventListener('DOMContentLoaded', initAdmin());

5
changelogs/unreleased/56622-admin-settings-cannot-read-property-addeventlistener-of-null.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Load initUserInternalRegexPlaceholder only when required
merge_request: 24522
author:
type: fixed

1
spec/javascripts/test_bundle.js
View file

@ -187,6 +187,7 @@ if (process.env.BABEL_ENV === 'coverage') {
'./terminal/terminal_bundle.js',
'./users/users_bundle.js',
'./issue_show/index.js',
'./pages/admin/application_settings/show/index.js',
];
describe('Uncovered files', function() {