kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Removes btn-transparent and btn-clipboard as default classes for clipboard button component 

Changes after review
This commit is contained in:
Filipa Lacerda 2018-03-05 11:59:50 +00:00
parent 35f6efaee0
commit 51b8874148
7 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/clusters/components/applications.vue
View File

@ -186,7 +186,7 @@
<clipboard-button
:text="ingressExternalIp"
:title="s__('ClusterIntegration|Copy Ingress IP Address to clipboard')"
css-class="btn btn-default js-clipboard-btn"
class="js-clipboard-btn"
/>
</span>
</div>

2
app/assets/javascripts/notes/components/diff_file_header.vue
View File

@ -35,6 +35,7 @@
<clipboard-button
title="Copy file path to clipboard"
:text="diffFile.submoduleLink"
css-class="btn-default btn-transparent btn-clipboard"
/>
</span>
</div>
@ -79,6 +80,7 @@
<clipboard-button
title="Copy file path to clipboard"
:text="diffFile.filePath"
css-class="btn-default btn-transparent btn-clipboard"
/>
<small

1
app/assets/javascripts/registry/components/collapsible_container.vue
View File

@ -86,6 +86,7 @@
v-if="repo.location"
:text="clipboardText"
:title="repo.location"
css-class="btn-default btn-transparent btn-clipboard"
/>
<div class="controls hidden-xs pull-right">

1
app/assets/javascripts/registry/components/table_registry.vue
View File

@ -90,6 +90,7 @@
v-if="item.location"
:title="item.location"
:text="clipboardText(item.location)"
css-class="btn-default btn-transparent btn-clipboard"
/>
</td>
<td>

1
app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue
View File

@ -67,6 +67,7 @@
<clipboard-button
:text="branchNameClipboardData"
:title="__('Copy branch name to clipboard')"
css-class="btn-default btn-transparent btn-clipboard"
/>
{{ s__("mrWidget|into") }}

3
app/assets/javascripts/vue_shared/components/clipboard_button.vue
View File

@ -31,7 +31,7 @@
cssClass: {
type: String,
required: false,
default: 'btn btn-default btn-transparent btn-clipboard',
default: 'btn-default',
},
},
};
@ -40,6 +40,7 @@
<template>
<button
type="button"
class="btn"
:class="cssClass"
:title="title"
:data-clipboard-text="text"

5
spec/javascripts/vue_shared/components/clipboard_button_spec.js
View File

@ -10,6 +10,7 @@ describe('clipboard button', () => {
vm = mountComponent(Component, {
text: 'copy me',
title: 'Copy this value into Clipboard!',
cssClass: 'btn-danger',
});
});
@ -28,4 +29,8 @@ describe('clipboard button', () => {
expect(vm.$el.getAttribute('data-placement')).toEqual('top');
expect(vm.$el.getAttribute('data-container')).toEqual(null);
});
it('should render provided classname', () => {
expect(vm.$el.classList).toContain('btn-danger');
});
});