kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

fixed up weird karma specs with tooltip

Browse source 
the tooltip mixin was changed because of a weird bug where the tooltip wouldn't show. This was wrong as the bug was actually caused by the text utility method
This commit is contained in:
Phil Hughes 2017-05-26 14:38:38 +01:00
parent 7f34b7cb16
commit 5227ea5bc4
3 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/issue_show/components/edit_actions.vue
View file

@ -48,7 +48,7 @@
class="btn btn-save pull-left"
:class="{ disabled: formState.updateLoading || !isSubmitEnabled }"
type="submit"
:disabled="updateLoading || !isSubmitEnabled"
:disabled="formState.updateLoading || !isSubmitEnabled"
@click.prevent="updateIssuable">
Save changes
<i

2
app/assets/javascripts/lib/utils/text_utility.js
View file

@ -170,7 +170,7 @@ gl.text.init = function(form) {
});
};
gl.text.removeListeners = function(form) {
return $('.js-md', form).off();
return $('.js-md', form).off('click');
};
gl.text.humanize = function(string) {
return string.charAt(0).toUpperCase() + string.replace(/_/g, ' ').slice(1);

8
app/assets/javascripts/vue_shared/mixins/tooltip.js
View file

@ -1,14 +1,10 @@
export default {
mounted() {
this.$nextTick(() => {
$(this.$refs.tooltip).tooltip();
});
$(this.$refs.tooltip).tooltip();
},
updated() {
this.$nextTick(() => {
$(this.$refs.tooltip).tooltip('fixTitle');
});
$(this.$refs.tooltip).tooltip('fixTitle');
},
beforeDestroy() {