Only escape the 'No Milestone' param

This is less invasive than the parent commit.
This commit is contained in:
Sean McGivern 2017-01-13 10:07:56 +00:00
parent b0ae433ef3
commit 52afe46380
2 changed files with 6 additions and 4 deletions

View File

@ -50,6 +50,8 @@ describe API::Issues, api: true do
end
let!(:note) { create(:note_on_issue, author: user, project: project, noteable: issue) }
let(:no_milestone_title) { URI.escape(Milestone::None.title) }
before do
project.team << [user, :reporter]
project.team << [guest, :guest]
@ -174,7 +176,7 @@ describe API::Issues, api: true do
end
it 'returns an array of issues with no milestone' do
get api("/issues?milestone=#{Milestone::None.title}", author)
get api("/issues?milestone=#{no_milestone_title}", author)
expect(response).to have_http_status(200)
expect(json_response).to be_an Array
@ -365,7 +367,7 @@ describe API::Issues, api: true do
end
it 'returns an array of issues with no milestone' do
get api("#{base_url}?milestone=#{Milestone::None.title}", user)
get api("#{base_url}?milestone=#{no_milestone_title}", user)
expect(response).to have_http_status(200)
expect(json_response).to be_an Array
@ -537,7 +539,7 @@ describe API::Issues, api: true do
end
it 'returns an array of issues with no milestone' do
get api("#{base_url}/issues?milestone=#{Milestone::None.title}", user)
get api("#{base_url}/issues?milestone=#{no_milestone_title}", user)
expect(response).to have_http_status(200)
expect(json_response).to be_an Array

View File

@ -18,7 +18,7 @@ module ApiHelpers
#
# Returns the relative path to the requested API resource
def api(path, user = nil)
"/api/#{API::API.version}#{URI.escape(path)}" +
"/api/#{API::API.version}#{path}" +
# Normalize query string
(path.index('?') ? '' : '?') +