kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Move the set up of the state described in context to a before block

Browse source
This commit is contained in:
Douglas Barbosa Alexandre 2016-08-17 12:15:51 -03:00
parent 84afd6254a
commit 536bdf643e
3 changed files with 21 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
spec/controllers/projects/boards/issues_controller_spec.rb
View file

@ -40,10 +40,12 @@ describe Projects::Boards::IssuesController do
end end
context 'with unauthorized user' do context 'with unauthorized user' do
it 'returns a successful 403 response' do before do
allow(Ability.abilities).to receive(:allowed?).with(user, :read_project, project).and_return(true) allow(Ability.abilities).to receive(:allowed?).with(user, :read_project, project).and_return(true)
allow(Ability.abilities).to receive(:allowed?).with(user, :read_issue, project).and_return(false) allow(Ability.abilities).to receive(:allowed?).with(user, :read_issue, project).and_return(false)
end
it 'returns a successful 403 response' do
list_issues user: user, list_id: list2 list_issues user: user, list_id: list2
expect(response).to have_http_status(403) expect(response).to have_http_status(403)

14
spec/controllers/projects/boards/lists_controller_spec.rb
View file

@ -33,13 +33,17 @@ describe Projects::Boards::ListsController do
expect(parsed_response.length).to eq 3 expect(parsed_response.length).to eq 3
end end
it 'returns a successful 403 response with unauthorized user' do context 'with unauthorized user' do
allow(Ability.abilities).to receive(:allowed?).with(user, :read_project, project).and_return(true) before do
allow(Ability.abilities).to receive(:allowed?).with(user, :read_list, project).and_return(false) allow(Ability.abilities).to receive(:allowed?).with(user, :read_project, project).and_return(true)
allow(Ability.abilities).to receive(:allowed?).with(user, :read_list, project).and_return(false)
end
read_board_list user: user it 'returns a successful 403 response' do
read_board_list user: user
expect(response).to have_http_status(403) expect(response).to have_http_status(403)
end
end end
def read_board_list(user:) def read_board_list(user:)

14
spec/controllers/projects/boards_controller_spec.rb
View file

@ -21,13 +21,17 @@ describe Projects::BoardsController do
expect(response.content_type).to eq 'text/html' expect(response.content_type).to eq 'text/html'
end end
it 'returns a successful 404 response with unauthorized user' do context 'with unauthorized user' do
allow(Ability.abilities).to receive(:allowed?).with(user, :read_project, project).and_return(true) before do
allow(Ability.abilities).to receive(:allowed?).with(user, :read_board, project).and_return(false) allow(Ability.abilities).to receive(:allowed?).with(user, :read_project, project).and_return(true)
allow(Ability.abilities).to receive(:allowed?).with(user, :read_board, project).and_return(false)
end
read_board it 'returns a successful 404 response' do
read_board
expect(response).to have_http_status(404) expect(response).to have_http_status(404)
end
end end
def read_board(format: :html) def read_board(format: :html)