kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Styling changes to code and docs

Browse source
This commit is contained in:
Robert Schilling 2016-04-13 12:50:00 +02:00
parent 3ab9ea8dae
commit 54231aa4e0
4 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
doc/api/projects.md
View file

@ -617,7 +617,6 @@ Example response:
}
```
### Archive a project
Archives the project if the user is either admin or the project owner of this project. This action is

2
lib/api/helpers.rb
View file

@ -242,7 +242,7 @@ module API
end
def not_modified!
render_api_error!('304 Not modified', 304)
render_api_error!('304 Not Modified', 304)
end
def render_validation_error!(model)

4
lib/api/projects.rb
View file

@ -284,6 +284,7 @@ module API
else
current_user.toggle_star(user_project)
user_project.reload
present user_project, with: Entities::Project
end
end
@ -293,11 +294,12 @@ module API
# Parameters:
# id (required) - The ID of a project
# Example Request:
# DELETE /projects/:id/unstar
# DELETE /projects/:id/star
delete ':id/star' do
if current_user.starred?(user_project)
current_user.toggle_star(user_project)
user_project.reload
present user_project, with: Entities::Project
else
not_modified!

10
spec/requests/api/projects_spec.rb
View file

@ -1023,7 +1023,7 @@ describe API::API, api: true do
describe 'POST /projects/:id/star' do
context 'on an unstarred project' do
it 'stars the project' do
post api("/projects/#{project.id}/star", user)
expect { post api("/projects/#{project.id}/star", user) }.to change { project.reload.star_count }.by(1)
expect(response.status).to eq(201)
expect(json_response['star_count']).to eq(1)
@ -1037,10 +1037,9 @@ describe API::API, api: true do
end
it 'does not modify the star count' do
post api("/projects/#{project.id}/star", user)
expect { post api("/projects/#{project.id}/star", user) }.not_to change { project.reload.star_count }
expect(response.status).to eq(304)
expect(project.star_count).to eq(1)
end
end
end
@ -1053,7 +1052,7 @@ describe API::API, api: true do
end
it 'unstars the project' do
delete api("/projects/#{project.id}/star", user)
expect { delete api("/projects/#{project.id}/star", user) }.to change { project.reload.star_count }.by(-1)
expect(response.status).to eq(200)
expect(json_response['star_count']).to eq(0)
@ -1062,10 +1061,9 @@ describe API::API, api: true do
context 'on an unstarred project' do
it 'does not modify the star count' do
delete api("/projects/#{project.id}/star", user)
expect { delete api("/projects/#{project.id}/star", user) }.not_to change { project.reload.star_count }
expect(response.status).to eq(304)
expect(project.star_count).to eq(0)
end
end
end