kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'jivl-fix-bar-char-transient-spec-failure' into 'master'

Browse source 
Fix transient failure from the bar_chart.vue component

Closes gitlab-ee#8062

See merge request gitlab-org/gitlab-ce!22495
This commit is contained in:
Filipa Lacerda 2018-10-19 15:56:08 +00:00
commit 54bd4b4f92
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
changelogs/unreleased/jivl-fix-bar-char-transient-spec-failure.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Fix transient spec error in the bar_chart component
merge_request: 22495
author:
type: fixed

6
spec/javascripts/vue_shared/components/bar_chart_spec.js
View file

@ -71,12 +71,6 @@ describe('Bar chart component', () => {
expect(barChart.xAxisLocation).toEqual('translate(100, 250)'); expect(barChart.xAxisLocation).toEqual('translate(100, 250)');
}); });
it('Contains a total of 4 ticks across the y axis', () => {
const ticks = barChart.$el.querySelector('.y-axis').querySelectorAll('.tick').length;
expect(ticks).toEqual(4);
});
it('rotates the x axis labels a total of 90 degress (CCW)', () => { it('rotates the x axis labels a total of 90 degress (CCW)', () => {
const xAxisLabel = barChart.$el.querySelector('.x-axis').querySelectorAll('text')[0]; const xAxisLabel = barChart.$el.querySelector('.x-axis').querySelectorAll('text')[0];