From 557cf4fa7633c65e7beacb273550de85cb9e130e Mon Sep 17 00:00:00 2001 From: Winnie Hellmann Date: Fri, 26 Oct 2018 11:04:45 +0200 Subject: [PATCH] Add dynamic timer for delayed jobs in pipelines list --- .../pipelines/components/pipelines_actions.vue | 10 +++------- .../unreleased/winh-pipeline-actions-dynamic-timer.yml | 5 +++++ spec/javascripts/pipelines/pipelines_actions_spec.js | 6 +++++- 3 files changed, 13 insertions(+), 8 deletions(-) create mode 100644 changelogs/unreleased/winh-pipeline-actions-dynamic-timer.yml diff --git a/app/assets/javascripts/pipelines/components/pipelines_actions.vue b/app/assets/javascripts/pipelines/components/pipelines_actions.vue index 16e69759091..d032ad73f71 100644 --- a/app/assets/javascripts/pipelines/components/pipelines_actions.vue +++ b/app/assets/javascripts/pipelines/components/pipelines_actions.vue @@ -1,9 +1,9 @@ @@ -100,7 +96,7 @@ export default { class="pull-right" > - {{ remainingTime(action) }} + diff --git a/changelogs/unreleased/winh-pipeline-actions-dynamic-timer.yml b/changelogs/unreleased/winh-pipeline-actions-dynamic-timer.yml new file mode 100644 index 00000000000..4ea1d3f8256 --- /dev/null +++ b/changelogs/unreleased/winh-pipeline-actions-dynamic-timer.yml @@ -0,0 +1,5 @@ +--- +title: Add dynamic timer for delayed jobs in pipelines list +merge_request: 22621 +author: +type: changed diff --git a/spec/javascripts/pipelines/pipelines_actions_spec.js b/spec/javascripts/pipelines/pipelines_actions_spec.js index b5c62178642..a7dcd532f4f 100644 --- a/spec/javascripts/pipelines/pipelines_actions_spec.js +++ b/spec/javascripts/pipelines/pipelines_actions_spec.js @@ -62,9 +62,13 @@ describe('Pipelines Actions dropdown', () => { ); }; - beforeEach(() => { + beforeEach(done => { spyOn(Date, 'now').and.callFake(() => new Date('2063-04-04T00:42:00Z').getTime()); vm = mountComponent(Component, { actions: [scheduledJobAction, expiredJobAction] }); + + Vue.nextTick() + .then(done) + .catch(done.fail); }); it('emits postAction event after confirming', () => {