kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove shared example and improve sub_group_issuables_spec.rb

Browse source
This commit is contained in:
Luke "Jared" Bennett 2017-05-25 15:26:18 +01:00
parent e048304456
commit 56797a84c8
No known key found for this signature in database
GPG key ID: 402ED51FB5D306C2
2 changed files with 17 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
spec/features/projects/sub_group_issuables_spec.rb
View file

@ -1,29 +1,32 @@
require 'spec_helper'
describe 'Subgroup Issuables', :feature, :js do
let!(:parent_group) { create(:group, name: 'parentgroup') }
let!(:subgroup) { create(:group, parent: parent_group, name: 'subgroup') }
let!(:project) { create(:empty_project, namespace: subgroup, name: 'project') }
let(:user) { create(:user) }
let!(:group) { create(:group, name: 'group') }
let!(:subgroup) { create(:group, parent: group, name: 'subgroup') }
let!(:project) { create(:empty_project, namespace: subgroup, name: 'project') }
let(:user) { create(:user) }
before do
project.add_master(user)
login_as user
end
context 'empty issues index' do
before do
visit namespace_project_issues_path(project.namespace, project)
end
it 'shows the full subgroup title when issues index page is empty' do
visit namespace_project_issues_path(project.namespace.to_param, project.to_param)
it_behaves_like 'has subgroup title', 'parentgroup', 'subgroup', 'project'
expect_to_have_full_subgroup_title
end
context 'empty merge request index' do
before do
visit namespace_project_merge_requests_path(project.namespace, project)
end
it 'shows the full subgroup title when merge requests index page is empty' do
visit namespace_project_merge_requests_path(project.namespace.to_param, project.to_param)
it_behaves_like 'has subgroup title', 'parentgroup', 'subgroup', 'project'
expect_to_have_full_subgroup_title
end
def expect_to_have_full_subgroup_title
title = find('.title-container')
expect(title).not_to have_selector '.initializing'
expect(title).to have_content 'group / subgroup / project'
end
end

8
spec/support/features/has_subgroup_title_spec.rb
View file

@ -1,8 +0,0 @@
shared_examples 'has subgroup title' do |parent_group_name, subgroup_name, project_name|
it 'shows the full title' do
title = find('.title-container')
expect(title).not_to have_selector '.initializing'
expect(title).to have_content "#{parent_group_name} / #{subgroup_name} / #{project_name}"
end
end