Make it clearer when Commit#description returns no_commit_message
This commit is contained in:
parent
e3f13c9e0a
commit
5759bfe029
|
@ -193,12 +193,9 @@ class Commit
|
|||
# otherwise returns commit message without first line
|
||||
def description
|
||||
return safe_message if full_title.length >= 100
|
||||
return no_commit_message if safe_message.blank?
|
||||
|
||||
if safe_message.blank?
|
||||
no_commit_message
|
||||
else
|
||||
safe_message.split("\n", 2)[1].try(:chomp)
|
||||
end
|
||||
safe_message.split("\n", 2)[1].try(:chomp)
|
||||
end
|
||||
|
||||
def description?
|
||||
|
|
|
@ -225,11 +225,12 @@ eos
|
|||
end
|
||||
|
||||
describe 'description' do
|
||||
it "returns no_commit_message when safe_message is blank" do
|
||||
allow(commit).to receive(:safe_message).and_return('')
|
||||
expect(commit.description).to eq("--no commit message")
|
||||
it 'returns no_commit_message when safe_message is blank' do
|
||||
allow(commit).to receive(:safe_message).and_return(nil)
|
||||
|
||||
expect(commit.description).to eq('--no commit message')
|
||||
end
|
||||
|
||||
|
||||
it 'returns description of commit message if title less than 100 characters' do
|
||||
message = <<eos
|
||||
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec sodales id felis id blandit.
|
||||
|
|
Loading…
Reference in New Issue