From 57d1bb82549c6713f87f87d5f35eec3d867c83db Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 19 May 2020 09:08:12 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .eslintrc.yml | 1 - .gitlab/ci/dev-fixtures.gitlab-ci.yml | 12 +- .gitlab/ci/frontend.gitlab-ci.yml | 9 +- .gitlab/ci/global.gitlab-ci.yml | 13 + .gitlab/ci/rails.gitlab-ci.yml | 27 +- .rubocop.yml | 4 + .../components/alert_details.vue | 14 +- .../fragments/detailItem.fragment.graphql | 11 + .../graphql/queries/details.query.graphql | 13 +- .../environments/components/container.vue | 2 +- .../components/delete_environment_modal.vue | 2 +- .../error_tracking/store/actions.js | 2 +- .../frequent_items/components/app.vue | 2 +- .../ide/components/new_dropdown/index.vue | 2 +- app/assets/javascripts/jobs/store/state.js | 2 +- .../notes/mixins/discussion_navigation.js | 2 +- .../application_settings/general/index.js | 2 +- .../settings/registry_settings_bundle.js | 2 +- .../components/assignees/assignees.vue | 4 +- .../components/edit_area.vue | 4 +- .../states/mr_widget_auto_merge_enabled.vue | 2 +- .../components/states/mr_widget_closed.vue | 2 +- .../components/states/mr_widget_merged.vue | 2 +- .../vue_shared/components/ci_icon.vue | 2 +- .../vue_shared/components/commit.vue | 2 +- .../components/file_finder/item.vue | 4 +- .../components/issue/issue_warning.vue | 2 +- .../issue/related_issuable_item.vue | 4 +- app/controllers/import/github_controller.rb | 2 +- app/controllers/projects_controller.rb | 2 +- app/models/application_setting.rb | 3 - app/models/concerns/has_user_type.rb | 1 + app/models/members/project_member.rb | 5 + ...namespace-id-and-clean-up-ghost-projec.yml | 5 + .../remove-experimental-indexer-column.yml | 5 + .../tr-alert-detail-remaining-fields.yml | 5 + changelogs/unreleased/update-css-loader.yml | 5 + ...ronments-delete_environment_modal-vue.yml} | 0 config/webpack.config.js | 3 +- ...roject_members_on_source_id_source_type.rb | 17 ++ ...ental_indexer_from_application_settings.rb | 8 + ..._add_projects_foreign_key_to_namespaces.rb | 27 ++ ...cleanup_projects_with_missing_namespace.rb | 263 ++++++++++++++++++ ...date_projects_foreign_key_to_namespaces.rb | 21 ++ db/structure.sql | 11 +- .../geo/replication/external_database.md | 13 + doc/api/instance_level_ci_variables.md | 25 +- doc/security/README.md | 4 +- package.json | 2 +- scripts/rspec_helpers.sh | 4 - .../application_controller_spec.rb | 6 +- .../settings/repository_controller_spec.rb | 2 +- .../projects/graphs_controller_spec.rb | 4 +- .../settings/repository_controller_spec.rb | 2 +- spec/db/schema_spec.rb | 2 +- .../filtered_search_manager_spec.js | 97 ++++--- .../recent_searches_root_spec.js | 8 +- .../frequent_items/components/app_spec.js | 34 +-- spec/frontend/frequent_items/mock_data.js | 127 ++++++++- .../frequent_items/store/actions_spec.js | 4 +- .../frequent_items/store/mutations_spec.js | 0 .../frequent_items/utils_spec.js | 14 +- spec/frontend/helpers/fixtures.js | 5 +- .../lib/utils/csrf_token_spec.js | 25 +- .../lib/utils/navigation_utility_spec.js | 6 +- .../lib/utils/poll_spec.js | 123 ++++---- .../lib/utils/sticky_spec.js | 23 +- .../notes/components/comment_form_spec.js | 7 +- .../components/discussion_actions_spec.js | 2 +- .../notes/components/discussion_notes_spec.js | 2 +- .../notes/components/notes_app_spec.js | 2 +- .../components/related_merge_requests_spec.js | 8 +- .../store/actions_spec.js | 13 +- .../store/mutations_spec.js | 0 spec/javascripts/frequent_items/mock_data.js | 168 ----------- spec/javascripts/sidebar/mock_data.js | 2 +- ...up_projects_with_missing_namespace_spec.rb | 134 +++++++++ spec/models/concerns/has_user_type_spec.rb | 6 + spec/models/project_spec.rb | 10 - ...mespaceless_project_destroy_worker_spec.rb | 14 - yarn.lock | 138 ++++----- 81 files changed, 1019 insertions(+), 550 deletions(-) create mode 100644 app/assets/javascripts/alert_management/graphql/fragments/detailItem.fragment.graphql create mode 100644 changelogs/unreleased/198603-add-foreign-key-on-projects-namespace-id-and-clean-up-ghost-projec.yml create mode 100644 changelogs/unreleased/remove-experimental-indexer-column.yml create mode 100644 changelogs/unreleased/tr-alert-detail-remaining-fields.yml create mode 100644 changelogs/unreleased/update-css-loader.yml rename changelogs/unreleased/{update-deprecated-slot-syntax-in---app-assets-javascripts-environments-co.yml => update-deprecated-slot-syntax-in---environments-delete_environment_modal-vue.yml} (100%) create mode 100644 db/migrate/20200515155620_add_index_non_requested_project_members_on_source_id_source_type.rb create mode 100644 db/post_migrate/20200428134356_remove_elastic_experimental_indexer_from_application_settings.rb create mode 100644 db/post_migrate/20200511080113_add_projects_foreign_key_to_namespaces.rb create mode 100644 db/post_migrate/20200511083541_cleanup_projects_with_missing_namespace.rb create mode 100644 db/post_migrate/20200511220023_validate_projects_foreign_key_to_namespaces.rb rename spec/{javascripts => frontend}/filtered_search/filtered_search_manager_spec.js (83%) rename spec/{javascripts => frontend}/filtered_search/recent_searches_root_spec.js (82%) rename spec/{javascripts => frontend}/frequent_items/components/app_spec.js (88%) rename spec/{javascripts => frontend}/frequent_items/store/actions_spec.js (97%) rename spec/{javascripts => frontend}/frequent_items/store/mutations_spec.js (100%) rename spec/{javascripts => frontend}/frequent_items/utils_spec.js (88%) rename spec/{javascripts => frontend}/lib/utils/csrf_token_spec.js (63%) rename spec/{javascripts => frontend}/lib/utils/navigation_utility_spec.js (80%) rename spec/{javascripts => frontend}/lib/utils/poll_spec.js (63%) rename spec/{javascripts => frontend}/lib/utils/sticky_spec.js (77%) rename spec/{javascripts => frontend}/related_merge_requests/components/related_merge_requests_spec.js (93%) rename spec/{javascripts => frontend}/related_merge_requests/store/actions_spec.js (87%) rename spec/{javascripts => frontend}/related_merge_requests/store/mutations_spec.js (100%) delete mode 100644 spec/javascripts/frequent_items/mock_data.js create mode 100644 spec/migrations/cleanup_projects_with_missing_namespace_spec.rb diff --git a/.eslintrc.yml b/.eslintrc.yml index 0cd1e7c5ec9..f8bc2a3ae94 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -32,7 +32,6 @@ rules: no-else-return: - error - allowElseIf: true - import/no-useless-path-segments: off lines-between-class-members: off # Disabled for now, to make the plugin-vue 4.5 -> 5.0 update smoother vue/no-confusing-v-for-v-if: error diff --git a/.gitlab/ci/dev-fixtures.gitlab-ci.yml b/.gitlab/ci/dev-fixtures.gitlab-ci.yml index 47acf8facc8..fc3678a7d17 100644 --- a/.gitlab/ci/dev-fixtures.gitlab-ci.yml +++ b/.gitlab/ci/dev-fixtures.gitlab-ci.yml @@ -1,7 +1,7 @@ .run-dev-fixtures: extends: - .default-retry - - .default-cache + - .rails-cache - .default-before_script - .use-pg11 stage: test @@ -19,8 +19,9 @@ run-dev-fixtures: - .run-dev-fixtures - .dev-fixtures:rules:ee-and-foss script: - - scripts/gitaly-test-spawn - - RAILS_ENV=test bundle exec rake db:seed_fu + - run_timed_command "scripts/gitaly-test-build" + - run_timed_command "scripts/gitaly-test-spawn" + - run_timed_command "RAILS_ENV=test bundle exec rake db:seed_fu" run-dev-fixtures-ee: extends: @@ -28,6 +29,7 @@ run-dev-fixtures-ee: - .dev-fixtures:rules:ee-only - .use-pg11-ee script: - - scripts/gitaly-test-spawn + - run_timed_command "scripts/gitaly-test-build" + - run_timed_command "scripts/gitaly-test-spawn" - cp ee/db/fixtures/development/* $FIXTURE_PATH - - RAILS_ENV=test bundle exec rake db:seed_fu + - run_timed_command "RAILS_ENV=test bundle exec rake db:seed_fu" diff --git a/.gitlab/ci/frontend.gitlab-ci.yml b/.gitlab/ci/frontend.gitlab-ci.yml index 1538352a881..6e9119f295a 100644 --- a/.gitlab/ci/frontend.gitlab-ci.yml +++ b/.gitlab/ci/frontend.gitlab-ci.yml @@ -136,16 +136,15 @@ compile-assets pull-cache as-if-foss: .frontend-fixtures-base: extends: - .default-retry - - .default-cache + - .rails-cache - .default-before_script - .use-pg11 stage: fixtures needs: ["setup-test-env", "compile-assets pull-cache"] script: - - date - - scripts/gitaly-test-spawn - - date - - bundle exec rake frontend:fixtures + - run_timed_command "scripts/gitaly-test-build" + - run_timed_command "scripts/gitaly-test-spawn" + - run_timed_command "bundle exec rake frontend:fixtures" artifacts: name: frontend-fixtures expire_in: 31d diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 74193b87e27..e6619ff2b6d 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -29,6 +29,19 @@ - vendor/gitaly-ruby policy: pull +.rails-cache: + cache: + key: + files: + - Gemfile.lock + - GITALY_SERVER_VERSION + prefix: "ruby-go-cache-v1" + paths: + - vendor/ruby + - vendor/gitaly-ruby + - .go/pkg/mod + policy: pull + .yarn-cache: cache: key: diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 0bf90e18bbd..e8087aebcef 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -1,15 +1,6 @@ .rails:needs:setup-and-assets: needs: ["setup-test-env", "compile-assets pull-cache"] -.rails-cache: - cache: - key: "ruby-go-cache-v1" - paths: - - vendor/ruby - - vendor/gitaly-ruby - - .go/pkg/mod - policy: pull - .rails-job-base: extends: - .default-retry @@ -18,15 +9,18 @@ ####################################################### # EE/FOSS: default refs (MRs, master, schedules) jobs # -.base-setup-test-env: +setup-test-env: extends: - .rails-job-base + - .rails:rules:default-refs-code-backstage-qa + - .use-pg11 stage: prepare variables: GITLAB_TEST_EAGER_LOAD: "0" script: - run_timed_command "bundle exec ruby -I. -e 'require \"config/environment\"; TestEnv.init'" - run_timed_command "scripts/gitaly-test-build" # Do not use 'bundle exec' here + - rm tmp/tests/gitaly/.ruby-bundle # This file prevents gems from being installed even if vendor/gitaly-ruby is missing artifacts: expire_in: 7d paths: @@ -44,12 +38,6 @@ cache: policy: pull-push -setup-test-env: - extends: - - .base-setup-test-env - - .rails:rules:default-refs-code-backstage-qa - - .use-pg11 - static-analysis: extends: - .rails-job-base @@ -84,6 +72,8 @@ downtime_check: stage: test needs: ["setup-test-env", "retrieve-tests-metadata", "compile-assets pull-cache"] script: + - run_timed_command "scripts/gitaly-test-build" + - run_timed_command "scripts/gitaly-test-spawn" - source scripts/rspec_helpers.sh - rspec_paralellized_job "--tag ~quarantine --tag ~geo --tag ~level:migration" artifacts: @@ -108,6 +98,8 @@ downtime_check: .rspec-base-migration: script: + - run_timed_command "scripts/gitaly-test-build" + - run_timed_command "scripts/gitaly-test-spawn" - source scripts/rspec_helpers.sh - rspec_paralellized_job "--tag ~quarantine --tag ~geo --tag level:migration" @@ -193,6 +185,7 @@ gitlab:setup: # db/fixtures/development/04_project.rb thanks to SIZE=1 below - git clone https://gitlab.com/gitlab-org/gitlab-test.git /home/git/repositories/gitlab-org/gitlab-test.git + - run_timed_command "scripts/gitaly-test-build" - run_timed_command "scripts/gitaly-test-spawn" - force=yes SIZE=1 FIXTURE_PATH="db/fixtures/development" bundle exec rake gitlab:setup artifacts: @@ -300,6 +293,8 @@ rspec-ee system pg11: .rspec-ee-base-geo: extends: .rspec-base-ee script: + - run_timed_command "scripts/gitaly-test-build" + - run_timed_command "scripts/gitaly-test-spawn" - source scripts/rspec_helpers.sh - scripts/prepare_postgres_fdw.sh - rspec_paralellized_job "--tag ~quarantine --tag geo" diff --git a/.rubocop.yml b/.rubocop.yml index 6687ada610a..439a22d00d3 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -466,8 +466,12 @@ Rails/TimeZone: Enabled: true EnforcedStyle: 'flexible' Include: + - 'app/controllers/**/*' - 'app/services/**/*' + - 'spec/controllers/**/*' - 'spec/services/**/*' + - 'ee/app/controllers/**/*' - 'ee/app/services/**/*' + - 'ee/spec/controllers/**/*' - 'ee/spec/services/**/*' diff --git a/app/assets/javascripts/alert_management/components/alert_details.vue b/app/assets/javascripts/alert_management/components/alert_details.vue index d042336c361..272caa11e03 100644 --- a/app/assets/javascripts/alert_management/components/alert_details.vue +++ b/app/assets/javascripts/alert_management/components/alert_details.vue @@ -12,7 +12,6 @@ import { GlButton, } from '@gitlab/ui'; import createFlash from '~/flash'; -import { capitalizeFirstCharacter } from '~/lib/utils/text_utility'; import { s__ } from '~/locale'; import query from '../graphql/queries/details.query.graphql'; import { fetchPolicies } from '~/lib/graphql'; @@ -23,9 +22,9 @@ import updateAlertStatus from '../graphql/mutations/update_alert_status.graphql' export default { statuses: { - triggered: s__('AlertManagement|Triggered'), - acknowledged: s__('AlertManagement|Acknowledged'), - resolved: s__('AlertManagement|Resolved'), + TRIGGERED: s__('AlertManagement|Triggered'), + ACKNOWLEDGED: s__('AlertManagement|Acknowledged'), + RESOLVED: s__('AlertManagement|Resolved'), }, i18n: { errorMsg: s__( @@ -100,7 +99,6 @@ export default { }, }, methods: { - capitalizeFirstCharacter, dismissError() { this.isErrorDismissed = true; }, @@ -177,11 +175,7 @@ export default { >

{{ alert.title }}

- + import { GlLoadingIcon } from '@gitlab/ui'; import TablePagination from '~/vue_shared/components/pagination/table_pagination.vue'; -import EnvironmentTable from '../components/environments_table.vue'; +import EnvironmentTable from './environments_table.vue'; export default { components: { diff --git a/app/assets/javascripts/environments/components/delete_environment_modal.vue b/app/assets/javascripts/environments/components/delete_environment_modal.vue index f731dc49a5b..29aab268fd3 100644 --- a/app/assets/javascripts/environments/components/delete_environment_modal.vue +++ b/app/assets/javascripts/environments/components/delete_environment_modal.vue @@ -52,7 +52,7 @@ export default { footer-primary-button-variant="danger" @submit="onSubmit" > -