kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'css-selector-format' into 'master' 

Disabled SelectorFormat rule for SCSS Lint in order to get the Rake
task passing sooner.

SelectorFormat enforces that CSS classes and IDs use lowercase
hyphenated style, `like-this`, but a not-insignificant amount of
selectors in the codebase are `like_this`.

Fixing the selectors that break this rule would require changing HTML
as well, and potentially break JavaScript hooks, among other things. So
I decided to disable this rule for the time being, hopefully making it
easier to fix all the remaining warnings SCSS Lint is giving by removing
the most problematic rule.

Discussed in #14299.

See merge request !3309
This commit is contained in:
Robert Speicher 2016-03-22 21:00:48 +00:00
parent 62ffdbeb2d 8d7ad53561
commit 57dd206f12
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.scss-lint.yml
View File

@ -100,7 +100,7 @@ linters:
# Selectors should always use hyphenated-lowercase, rather than camelCase or
# snake_case.
SelectorFormat:
enabled: true
enabled: false
convention: hyphenated_lowercase
# Prefer the shortest shorthand form possible for properties that support it.