Refactor `add_recipients`

2018-04-09 19:16:40 +11:00 · 2018-04-09 19:16:40 +11:00 · 58dd4a095f
parent b8c098ecfa
commit 58dd4a095f
1 changed files with 2 additions and 3 deletions
--- a/app/services/notification_recipient_service.rb
+++ b/app/services/notification_recipient_service.rb
@ -51,11 +51,10 @@ module NotificationRecipientService

      def add_recipients(users, type, reason)
        if users.is_a?(ActiveRecord::Relation)
-          users = users.includes(:notification_settings).to_a
+          users = users.includes(:notification_settings)
        end

-        users = Array(users)
-        users.compact!
+        users = Array(users).compact
        recipients.concat(users.map { |u| make_recipient(u, type, reason) })
      end