kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Don't set invalid @mr_source_branch when create_merge_request?

Browse source
This commit is contained in:
Lin Jen-Shin 2017-01-06 20:59:38 +08:00
parent dea589d635
commit 593228ffe3
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/controllers/concerns/creates_commit.rb
View file

@ -91,16 +91,13 @@ module CreatesCommit
@mr_source_project != @mr_target_project
end
def different_branch?
@mr_source_branch != @mr_target_branch || different_project?
end
def create_merge_request?
params[:create_merge_request].present? && different_branch?
params[:create_merge_request].present?
end
# TODO: We should really clean this up
def set_commit_variables
@mr_source_branch ||= @target_branch
@mr_source_branch = @target_branch unless create_merge_request?
if can?(current_user, :push_code, @project)
# Edit file in this project