Use title as placeholder instead of issue title for reusability

This commit is contained in:
Clement Ho 2017-10-20 19:26:51 +00:00 committed by Filipa Lacerda
parent 81175d2c37
commit 59c03de56d
4 changed files with 12 additions and 7 deletions

View file

@ -16,15 +16,15 @@
<fieldset>
<label
class="sr-only"
for="issue-title">
for="issuable-title">
Title
</label>
<input
id="issue-title"
id="issuable-title"
class="form-control"
type="text"
placeholder="Issue title"
aria-label="Issue title"
placeholder="Title"
aria-label="Title"
v-model="formState.title"
@keydown.meta.enter="updateIssuable"
@keydown.ctrl.enter="updateIssuable" />

View file

@ -0,0 +1,5 @@
---
title: Use title as placeholder instead of issue title for reusability
merge_request:
author:
type: other

View file

@ -25,7 +25,7 @@ feature 'Issue Detail', :js do
wait_for_requests
click_link 'Edit'
fill_in 'issue-title', with: 'issue title'
fill_in 'issuable-title', with: 'issue title'
click_button 'Save'
Users::DestroyService.new(user).execute(user)

View file

@ -35,7 +35,7 @@ feature 'issuable templates', :js do
page.within('.content .issuable-actions') do
click_on 'Edit'
end
fill_in :'issue-title', with: 'test issue title'
fill_in :'issuable-title', with: 'test issue title'
end
scenario 'user selects "bug" template' do
@ -80,7 +80,7 @@ feature 'issuable templates', :js do
page.within('.content .issuable-actions') do
click_on 'Edit'
end
fill_in :'issue-title', with: 'test issue title'
fill_in :'issuable-title', with: 'test issue title'
fill_in :'issue-description', with: prior_description
end