Avoid close icon leaving the modal header

2018-10-02 21:58:57 +00:00 · 2018-10-02 21:58:57 +00:00 · 59d4a86014
parent 9087964c8c
commit 59d4a86014
2 changed files with 16 additions and 0 deletions
--- a/app/assets/stylesheets/framework/modal.scss
+++ b/app/assets/stylesheets/framework/modal.scss
@ -19,6 +19,17 @@
    }
  }

+  // leave enough space for the close icon
+  .modal-title {
+    &.mw-100,
+    &.w-100 {
+      // after upgrading to Bootstrap 4.2 we can use $modal-header-padding-x here
+      // https://github.com/twbs/bootstrap/pull/26976
+      margin-right: -2rem;
+      padding-right: 2rem;
+    }
+  }
+
  .page-title {
    margin-top: 0;
  }
--- a/changelogs/unreleased/feature-flags-mvc.yml
+++ b/changelogs/unreleased/feature-flags-mvc.yml
@ -0,0 +1,5 @@
+---
+title: Avoid close icon leaving the modal header
+merge_request: 21904
+author:
+type: changed