Encode Page-Title header as ISO-8859-1

2017-09-26 18:05:19 +02:00 · 2017-09-26 18:05:19 +02:00 · 5adae3d85b
parent e441279904
commit 5adae3d85b
1 changed files with 2 additions and 1 deletions
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@ -339,6 +339,7 @@ class ApplicationController < ActionController::Base
  end

  def set_page_title_header
-    response.headers['Page-Title'] = page_title('GitLab')
+    # Per https://tools.ietf.org/html/rfc5987, headers need to be ISO-8859-1, not UTF-8
+    response.headers['Page-Title'] = page_title('GitLab').encode('ISO-8859-1')
  end
 end