kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add the same gurad clause with artifacts uplaoding

Browse source
This commit is contained in:
Shinya Maeda 2018-05-18 16:05:11 +09:00
parent 93349b4440
commit 5af5815d62
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/api/runner.rb
View file

@ -149,6 +149,7 @@ module API
end end
patch '/:id/trace' do patch '/:id/trace' do
job = authenticate_job! job = authenticate_job!
forbidden!('Job is not running') unless job.running?
error!('400 Missing header Content-Range', 400) unless request.headers.key?('Content-Range') error!('400 Missing header Content-Range', 400) unless request.headers.key?('Content-Range')
content_range = request.headers['Content-Range'] content_range = request.headers['Content-Range']
@ -165,7 +166,7 @@ module API
body_start = content_range[0].to_i body_start = content_range[0].to_i
body_end = body_start + body_data.bytesize body_end = body_start + body_data.bytesize
stream_size = job.trace.append(body_data, body_start) if job.running? stream_size = job.trace.append(body_data, body_start)
unless stream_size == body_end unless stream_size == body_end
break error!('416 Range Not Satisfiable', 416, { 'Range' => "0-#{stream_size}" }) break error!('416 Range Not Satisfiable', 416, { 'Range' => "0-#{stream_size}" })
end end