kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix double event and xhr request call on MR page !7298 

On page merge_requests/n/diffs and merge_requests/n/commits 'shown.bs.tab' event triggers twice when tab is loading  which lead to  extra ajax request for data each time.
This commit prevent this event from triggering twice when tab is loading.
This commit is contained in:
Yar 2016-11-13 18:18:04 +03:00 committed by YarNayar
parent 7957b20405
commit 5b876592b4
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/merge_request_tabs.js
View File

@ -145,7 +145,8 @@
if (action === 'show') {
action = 'notes';
}
$(".merge-request-tabs a[data-action='" + action + "']").tab('show').trigger('shown.bs.tab');
// important note: the .tab('show') method triggers 'shown.bs.tab' event itself
$(".merge-request-tabs a[data-action='" + action + "']").tab('show');
};
// Replaces the current Merge Request-specific action in the URL with a new one

4
changelogs/unreleased/24010-double-event-trigger.yml Normal file
View File

@ -0,0 +1,4 @@
---
title: Fix double event and ajax request call on MR page
merge_request: 7298
author: YarNayar