From 5c5d24f032b67d98452f391192386e330a0f880c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 18 Jul 2022 12:08:41 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/cop/user_admin.yml | 5 - .../gitlab/feature_available_usage.yml | 23 -- .rubocop_todo/gitlab/namespaced_class.yml | 1 - .rubocop_todo/layout/argument_alignment.yml | 1 - .rubocop_todo/layout/hash_alignment.yml | 1 - .rubocop_todo/layout/line_length.yml | 9 - .../multiline_operation_indentation.yml | 1 - .rubocop_todo/layout/space_inside_parens.yml | 1 - .../rescued_exceptions_variable_name.yml | 1 - .rubocop_todo/rails/pluck.yml | 1 - .rubocop_todo/rails/squished_sql_heredocs.yml | 1 - .rubocop_todo/rails/time_zone.yml | 1 - .rubocop_todo/rspec/any_instance_of.yml | 31 -- .rubocop_todo/rspec/context_wording.yml | 4 - .rubocop_todo/rspec/expect_change.yml | 1 - .rubocop_todo/rspec/expect_in_hook.yml | 1 - .../rspec/multiple_memoized_helpers.yml | 2 - .rubocop_todo/rspec/verified_doubles.yml | 11 - .../style/explicit_block_argument.yml | 1 - .rubocop_todo/style/format_string.yml | 4 - .rubocop_todo/style/if_unless_modifier.yml | 3 - .../style/percent_literal_delimiters.yml | 1 - Gemfile | 2 +- Gemfile.lock | 4 +- .../services/hast_to_prosemirror_converter.js | 7 +- .../services/remark_markdown_deserializer.js | 18 +- .../notes/components/comment_form.vue | 5 +- .../components/details/file_sha.vue | 20 ++ .../components/details/package_files.vue | 24 +- .../package_registry/constants.js | 7 + .../package_registry/pages/details.vue | 6 +- .../shared/constants/package_registry.js | 2 + .../releases/components/app_edit_new.vue | 4 + .../releases/components/app_index.vue | 18 +- .../components/confirm_delete_modal.vue | 77 +++++ .../release_for_editing.fragment.graphql | 1 + .../mutations/delete_release.mutation.graphql | 5 + .../javascripts/releases/mount_index.js | 2 + .../stores/modules/edit_new/actions.js | 30 +- .../stores/modules/edit_new/getters.js | 7 + .../releases/stores/modules/edit_new/state.js | 2 + app/assets/javascripts/releases/util.js | 2 + app/controllers/projects/issues_controller.rb | 1 - .../projects/merge_requests_controller.rb | 1 - app/helpers/releases_helper.rb | 3 +- app/models/ci/build.rb | 2 - app/models/members/project_member.rb | 2 +- .../timeline_event_policy.rb | 10 + .../timeline_events/update_service.rb | 5 +- app/views/dashboard/todos/_todo.html.haml | 10 +- .../development/confidential_notes.yml | 8 - doc/api/deployments.md | 4 +- doc/ci/variables/index.md | 2 +- doc/user/discussions/index.md | 6 +- doc/user/project/releases/index.md | 19 ++ glfm_specification/example_snapshots/html.yml | 198 +++++++++-- .../example_snapshots/prosemirror_json.yml | 315 ++++++++++++++++-- locale/gitlab.pot | 27 +- package.json | 4 +- .../remark_markdown_processing_spec.js | 42 ++- .../render_html_and_json_for_all_examples.js | 4 +- .../notes/components/comment_form_spec.js | 130 +++----- .../releases/__snapshots__/util_spec.js.snap | 1 + .../releases/components/app_edit_new_spec.js | 29 ++ .../releases/components/app_index_spec.js | 31 ++ .../components/confirm_delete_modal_spec.js | 89 +++++ .../stores/modules/detail/actions_spec.js | 134 +++++++- .../stores/modules/detail/getters_spec.js | 20 ++ spec/helpers/releases_helper_spec.rb | 3 +- spec/initializers/0_log_deprecations_spec.rb | 9 +- spec/models/members/project_member_spec.rb | 20 +- .../timeline_event_policy_spec.rb | 60 ++++ spec/requests/api/invitations_spec.rb | 2 +- spec/requests/api/projects_spec.rb | 2 +- .../timeline_events/update_service_spec.rb | 6 +- .../gitlab_stubs/gitlab_ci_dast_includes.yml | 10 + yarn.lock | 16 +- 77 files changed, 1257 insertions(+), 316 deletions(-) create mode 100644 app/assets/javascripts/releases/components/confirm_delete_modal.vue create mode 100644 app/assets/javascripts/releases/graphql/mutations/delete_release.mutation.graphql delete mode 100644 config/feature_flags/development/confidential_notes.yml create mode 100644 spec/frontend/releases/components/confirm_delete_modal_spec.js create mode 100644 spec/policies/incident_management/timeline_event_policy_spec.rb create mode 100644 spec/support/gitlab_stubs/gitlab_ci_dast_includes.yml diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index ab5f76a002d..c9eed57e74d 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -2,7 +2,6 @@ Cop/UserAdmin: Exclude: - app/controllers/admin/impersonations_controller.rb - - app/controllers/concerns/spammable_actions.rb - app/controllers/sessions_controller.rb - app/finders/autocomplete/routes_finder.rb - app/finders/ci/jobs_finder.rb @@ -32,8 +31,6 @@ Cop/UserAdmin: - app/services/projects/fork_service.rb - app/services/users/build_service.rb - ee/app/controllers/ee/projects_controller.rb - - ee/app/graphql/mutations/admin/analytics/devops_adoption/segments/mixins.rb - - ee/app/graphql/resolvers/admin/analytics/devops_adoption/segments_resolver.rb - ee/app/helpers/ee/dashboard_helper.rb - ee/app/helpers/ee/import_helper.rb - ee/app/helpers/ee/subscribable_banner_helper.rb @@ -53,7 +50,6 @@ Cop/UserAdmin: - lib/api/award_emoji.rb - lib/api/ci/runners.rb - lib/api/entities/ci/runner_details.rb - - lib/api/entities/ci/user_safe.rb - lib/api/groups.rb - lib/api/helpers.rb - lib/api/personal_access_tokens.rb @@ -61,7 +57,6 @@ Cop/UserAdmin: - lib/api/v3/github.rb - lib/constraints/admin_constrainer.rb - lib/gitlab/auth.rb - - lib/gitlab/background_migration/user_mentions/models/group.rb - lib/gitlab/ci/runner_instructions.rb - lib/gitlab/import_export/members_mapper.rb - lib/gitlab/performance_bar.rb diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 99a3ef03e4e..92aad8b990e 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -6,7 +6,6 @@ Gitlab/FeatureAvailableUsage: - app/helpers/events_helper.rb - app/helpers/labels_helper.rb - app/policies/project_policy.rb - - app/views/shared/boards/_switcher.html.haml - ee/app/controllers/concerns/description_diff_actions.rb - ee/app/controllers/concerns/ee/boards_actions.rb - ee/app/controllers/concerns/security_dashboards_permissions.rb @@ -18,23 +17,18 @@ Gitlab/FeatureAvailableUsage: - ee/app/controllers/ee/projects/settings/operations_controller.rb - ee/app/controllers/ee/projects/settings/repository_controller.rb - ee/app/controllers/projects/audit_events_controller.rb - - ee/app/controllers/projects/cluster_agents_controller.rb - - ee/app/controllers/projects/iterations/inherited_controller.rb - ee/app/controllers/projects/iterations_controller.rb - ee/app/controllers/projects/path_locks_controller.rb - ee/app/controllers/projects/subscriptions_controller.rb - ee/app/finders/autocomplete/vulnerabilities_autocomplete_finder.rb - - ee/app/finders/clusters/agents_finder.rb - ee/app/finders/ee/alert_management/http_integrations_finder.rb - ee/app/graphql/ee/types/group_type.rb - ee/app/graphql/mutations/dast/profiles/create.rb - ee/app/graphql/mutations/dast/profiles/run.rb - ee/app/graphql/mutations/dast/profiles/update.rb - ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb - - ee/app/graphql/resolvers/clusters/agent_tokens_resolver.rb - ee/app/helpers/ee/application_helper.rb - ee/app/helpers/ee/boards_helper.rb - - ee/app/helpers/ee/clusters_helper.rb - ee/app/helpers/ee/dashboard_helper.rb - ee/app/helpers/ee/form_helper.rb - ee/app/helpers/ee/graph_helper.rb @@ -50,7 +44,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/models/concerns/approvable.rb - ee/app/models/concerns/ee/project_security_scanners_information.rb - ee/app/models/concerns/ee/protected_ref_access.rb - - ee/app/models/concerns/has_timelogs_report.rb - ee/app/models/concerns/insights_feature.rb - ee/app/models/ee/board.rb - ee/app/models/ee/ci/build.rb @@ -66,11 +59,9 @@ Gitlab/FeatureAvailableUsage: - ee/app/models/ee/namespace_setting.rb - ee/app/models/ee/project.rb - ee/app/models/ee/project_ci_cd_setting.rb - - ee/app/models/namespace_statistics.rb - ee/app/models/project_security_setting.rb - ee/app/policies/compliance_management/framework_policy.rb - ee/app/policies/ee/group_policy.rb - - ee/app/policies/ee/namespace_policy.rb - ee/app/policies/ee/project_policy.rb - ee/app/policies/ee/protected_branch_policy.rb - ee/app/presenters/ee/label_presenter.rb @@ -81,17 +72,8 @@ Gitlab/FeatureAvailableUsage: - ee/app/serializers/ee/note_entity.rb - ee/app/services/boards/epic_boards/update_service.rb - ee/app/services/ci/audit_variable_change_service.rb - - ee/app/services/clusters/agent_tokens/create_service.rb - - ee/app/services/clusters/agents/create_service.rb - ee/app/services/dashboard/projects/create_service.rb - ee/app/services/dashboard/projects/list_service.rb - - ee/app/services/dast/profiles/create_service.rb - - ee/app/services/dast/profiles/update_service.rb - - ee/app/services/dast_on_demand_scans/create_service.rb - - ee/app/services/dast_site_tokens/create_service.rb - - ee/app/services/dast_site_validations/create_service.rb - - ee/app/services/dast_site_validations/revoke_service.rb - - ee/app/services/dast_site_validations/validate_service.rb - ee/app/services/ee/alert_management/http_integrations/create_service.rb - ee/app/services/ee/audit_event_service.rb - ee/app/services/ee/boards/issues/list_service.rb @@ -119,8 +101,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/services/quality_management/test_cases/create_service.rb - ee/app/services/requirements_management/process_test_reports_service.rb - ee/app/services/security/store_scans_service.rb - - ee/app/views/layouts/nav/_test_cases_link.html.haml - - ee/app/views/layouts/nav/sidebar/_project_iterations_link.html.haml - ee/app/views/projects/_merge_request_approvals_settings.html.haml - ee/app/views/projects/_merge_request_settings.html.haml - ee/app/views/projects/_merge_request_settings_description_text.html.haml @@ -140,7 +120,6 @@ Gitlab/FeatureAvailableUsage: - ee/app/views/projects/settings/ci_cd/_pipeline_subscriptions.html.haml - ee/app/views/projects/settings/operations/_status_page.html.haml - ee/app/views/projects/settings/repository/_protected_branches.html.haml - - ee/app/views/projects/sidebar/_repository_locked_files.html.haml - ee/app/views/shared/issuable/_group_bulk_update_sidebar.html.haml - ee/app/views/shared/issuable/form/_default_templates.html.haml - ee/app/views/shared/labels/_create_label_help_text.html.haml @@ -148,14 +127,12 @@ Gitlab/FeatureAvailableUsage: - ee/app/views/shared/promotions/_promote_repository_features.html.haml - ee/app/workers/analytics/code_review_metrics_worker.rb - ee/app/workers/group_saml_group_sync_worker.rb - - ee/lib/api/external_status_checks.rb - ee/lib/ee/api/entities/approval_state.rb - ee/lib/ee/api/entities/board.rb - ee/lib/ee/api/entities/issue.rb - ee/lib/ee/api/entities/project.rb - ee/lib/ee/api/helpers.rb - ee/lib/ee/api/internal/kubernetes.rb - - ee/lib/ee/api/job_artifacts.rb - ee/lib/ee/api/projects.rb - ee/lib/ee/gitlab/alert_management/payload/generic.rb - ee/lib/ee/gitlab/checks/diff_check.rb diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 16727389a31..e41736e8b5f 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -793,7 +793,6 @@ Gitlab/NamespacedClass: - 'app/workers/pages_domain_ssl_renewal_worker.rb' - 'app/workers/pages_domain_verification_cron_worker.rb' - 'app/workers/pages_domain_verification_worker.rb' - - 'app/workers/pages_transfer_worker.rb' - 'app/workers/pages_worker.rb' - 'app/workers/partition_creation_worker.rb' - 'app/workers/pipeline_hooks_worker.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index c9270224a0c..1977bedd143 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -476,7 +476,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' diff --git a/.rubocop_todo/layout/hash_alignment.yml b/.rubocop_todo/layout/hash_alignment.yml index 2796d4dec4a..d6772537f47 100644 --- a/.rubocop_todo/layout/hash_alignment.yml +++ b/.rubocop_todo/layout/hash_alignment.yml @@ -356,7 +356,6 @@ Layout/HashAlignment: - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' - 'ee/app/services/groups/memberships/export_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - 'ee/app/services/projects/setup_ci_cd.rb' - 'ee/app/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service.rb' - 'ee/config/routes/project.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 5154aa02c2e..810b5e1dffe 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -564,7 +564,6 @@ Layout/LineLength: - 'app/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service.rb' - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/prometheus_metrics/observe_histograms_service.rb' - - 'app/services/ci/queue/builds_table_strategy.rb' - 'app/services/ci/queue/pending_builds_strategy.rb' - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/runners/unregister_runner_service.rb' @@ -617,7 +616,6 @@ Layout/LineLength: - 'app/services/import/bitbucket_server_service.rb' - 'app/services/import/github_service.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/issuable/import_csv/base_service.rb' - 'app/services/issuable/process_assignees.rb' - 'app/services/issuable_base_service.rb' @@ -1545,8 +1543,6 @@ Layout/LineLength: - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' - 'ee/app/services/merge_trains/create_pipeline_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/personal_access_tokens/rotation_verifier_service.rb' - 'ee/app/services/projects/licenses/create_policy_service.rb' - 'ee/app/services/projects/mark_for_deletion_service.rb' @@ -1555,7 +1551,6 @@ Layout/LineLength: - 'ee/app/services/resource_events/change_weight_service.rb' - 'ee/app/services/security/auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' - - 'ee/app/services/security/ingestion/bulk_updatable_task.rb' - 'ee/app/services/security/ingestion/finding_map.rb' - 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/create.rb' @@ -2879,7 +2874,6 @@ Layout/LineLength: - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/namespaces/check_excess_storage_size_service_spec.rb' - 'ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb' - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' @@ -3033,7 +3027,6 @@ Layout/LineLength: - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - - 'ee/spec/views/projects/protected_environments/_protected_environment.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' @@ -3772,7 +3765,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/personal_project_permissions_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' @@ -5887,7 +5879,6 @@ Layout/LineLength: - 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb' - 'spec/services/integrations/propagate_service_spec.rb' - 'spec/services/issuable/bulk_update_service_spec.rb' - - 'spec/services/issuable/clone/attributes_rewriter_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issuable/destroy_service_spec.rb' - 'spec/services/issue_links/create_service_spec.rb' diff --git a/.rubocop_todo/layout/multiline_operation_indentation.yml b/.rubocop_todo/layout/multiline_operation_indentation.yml index a00d759482a..51ecf97d318 100644 --- a/.rubocop_todo/layout/multiline_operation_indentation.yml +++ b/.rubocop_todo/layout/multiline_operation_indentation.yml @@ -71,7 +71,6 @@ Layout/MultilineOperationIndentation: - 'lib/gitlab/ci/reports/security/finding_key.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/gl_repository/repo_type.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 14a5fffa417..1ba43d3b019 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -44,7 +44,6 @@ Layout/SpaceInsideParens: - 'ee/app/services/compliance_management/frameworks/destroy_service.rb' - 'ee/app/services/compliance_management/frameworks/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/sitemap/create_service.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/gitlab/auth/smartcard/session.rb' diff --git a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml index f6416bed902..b557ca8f06e 100644 --- a/.rubocop_todo/naming/rescued_exceptions_variable_name.yml +++ b/.rubocop_todo/naming/rescued_exceptions_variable_name.yml @@ -22,7 +22,6 @@ Naming/RescuedExceptionsVariableName: - 'app/models/blob_viewer/metrics_dashboard_yml.rb' - 'app/models/ci/build.rb' - 'app/models/ci/deleted_object.rb' - - 'app/models/clusters/concerns/elasticsearch_client.rb' - 'app/models/concerns/prometheus_adapter.rb' - 'app/models/concerns/repository_storage_movable.rb' - 'app/models/concerns/x509_serial_number_attribute.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 860b772d913..5e875daa569 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -14,7 +14,6 @@ Rails/Pluck: - 'app/models/list.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb' - 'app/services/feature_flags/update_service.rb' - - 'app/services/pod_logs/base_service.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - 'ee/app/models/boards/epic_list.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' diff --git a/.rubocop_todo/rails/squished_sql_heredocs.yml b/.rubocop_todo/rails/squished_sql_heredocs.yml index dc71b7b32ce..3696f661893 100644 --- a/.rubocop_todo/rails/squished_sql_heredocs.yml +++ b/.rubocop_todo/rails/squished_sql_heredocs.yml @@ -108,7 +108,6 @@ Rails/SquishedSQLHeredocs: - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/vulnerabilities/statistic.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - - 'ee/app/services/security/ingestion/bulk_updatable_task.rb' - 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_statistics.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 48e559312f8..8931b337ce1 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -121,7 +121,6 @@ Rails/TimeZone: - spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb - spec/lib/gitlab/prometheus/queries/validate_query_spec.rb - spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb - - spec/lib/gitlab/updated_notes_paginator_spec.rb - spec/lib/gitlab/utils/json_size_estimator_spec.rb - spec/lib/gitlab/x509/signature_spec.rb - spec/lib/grafana/time_window_spec.rb diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 49699f09787..2cc2478e530 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -47,7 +47,6 @@ RSpec/AnyInstanceOf: - ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb - - ee/spec/lib/gitlab/ci/templates/api_fuzzing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb - ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb @@ -59,14 +58,7 @@ RSpec/AnyInstanceOf: - ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb - ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb - ee/spec/lib/omni_auth/strategies/group_saml_spec.rb - - ee/spec/lib/security/ci_configuration/sast_build_actions_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - - ee/spec/migrations/schedule_populate_resolved_on_default_branch_column_spec.rb - - ee/spec/migrations/update_location_fingerprint_column_for_cs_spec.rb - - ee/spec/migrations/update_occurrence_severity_column_spec.rb - - ee/spec/migrations/update_undefined_confidence_from_occurrences_spec.rb - - ee/spec/migrations/update_undefined_confidence_from_vulnerabilities_spec.rb - - ee/spec/migrations/update_vulnerability_severity_column_spec.rb - ee/spec/models/ee/namespace_spec.rb - ee/spec/models/geo_node_status_spec.rb - ee/spec/models/issue_spec.rb @@ -74,23 +66,18 @@ RSpec/AnyInstanceOf: - ee/spec/models/project_import_state_spec.rb - ee/spec/models/push_rule_spec.rb - ee/spec/presenters/ci/pipeline_presenter_spec.rb - - ee/spec/presenters/projects/security/configuration_presenter_spec.rb - ee/spec/requests/api/geo_nodes_spec.rb - ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb - - ee/spec/requests/api/graphql/mutations/pipelines/run_dast_scan_spec.rb - ee/spec/requests/api/issues_spec.rb - ee/spec/requests/api/projects_spec.rb - ee/spec/requests/git_http_spec.rb - ee/spec/requests/groups_controller_spec.rb - ee/spec/requests/omniauth_kerberos_spnego_spec.rb - ee/spec/requests/repositories/git_http_controller_spec.rb - - ee/spec/services/ci/expire_pipeline_cache_service_spec.rb - - ee/spec/services/ci/run_dast_scan_service_spec.rb - ee/spec/services/ee/git/branch_push_service_spec.rb - ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb - ee/spec/services/ee/merge_requests/refresh_service_spec.rb - - ee/spec/services/ee/security/ingress_modsecurity_usage_service_spec.rb - ee/spec/services/ee/users/create_service_spec.rb - ee/spec/services/ee/users/destroy_service_spec.rb - ee/spec/services/geo/container_repository_sync_service_spec.rb @@ -118,7 +105,6 @@ RSpec/AnyInstanceOf: - ee/spec/support/shared_examples/models/member_shared_examples.rb - ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb - ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb - - ee/spec/workers/build_finished_worker_spec.rb - ee/spec/workers/concerns/elastic/indexing_control_spec.rb - ee/spec/workers/elastic_commit_indexer_worker_spec.rb - ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb @@ -155,7 +141,6 @@ RSpec/AnyInstanceOf: - spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb - spec/controllers/projects/settings/integrations_controller_spec.rb - spec/controllers/projects/tags_controller_spec.rb - - spec/controllers/registrations/experience_levels_controller_spec.rb - spec/controllers/registrations_controller_spec.rb - spec/controllers/sessions_controller_spec.rb - spec/controllers/snippets/notes_controller_spec.rb @@ -176,7 +161,6 @@ RSpec/AnyInstanceOf: - spec/features/projects/files/user_browses_lfs_files_spec.rb - spec/features/projects/jobs_spec.rb - spec/features/projects/navbar_spec.rb - - spec/features/projects/pages_spec.rb - spec/features/projects/settings/service_desk_setting_spec.rb - spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb - spec/features/snippets/embedded_snippet_spec.rb @@ -190,7 +174,6 @@ RSpec/AnyInstanceOf: - spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb - spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb - spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb - - spec/helpers/analytics/unique_visits_helper_spec.rb - spec/helpers/projects_helper_spec.rb - spec/initializers/lograge_spec.rb - spec/lib/api/entities/merge_request_basic_spec.rb @@ -211,8 +194,6 @@ RSpec/AnyInstanceOf: - spec/lib/gitlab/auth/blocked_user_tracker_spec.rb - spec/lib/gitlab/auth/request_authenticator_spec.rb - spec/lib/gitlab/auth_spec.rb - - spec/lib/gitlab/background_migration/populate_personal_snippet_statistics_spec.rb - - spec/lib/gitlab/background_migration/populate_project_snippet_statistics_spec.rb - spec/lib/gitlab/checks/diff_check_spec.rb - spec/lib/gitlab/checks/lfs_check_spec.rb - spec/lib/gitlab/checks/lfs_integrity_spec.rb @@ -231,8 +212,6 @@ RSpec/AnyInstanceOf: - spec/lib/gitlab/ci/templates/npm_spec.rb - spec/lib/gitlab/ci/trace_spec.rb - spec/lib/gitlab/current_settings_spec.rb - - spec/lib/gitlab/cycle_analytics/base_event_fetcher_spec.rb - - spec/lib/gitlab/database/multi_threaded_migration_spec.rb - spec/lib/gitlab/diff/highlight_cache_spec.rb - spec/lib/gitlab/diff/highlight_spec.rb - spec/lib/gitlab/diff/position_spec.rb @@ -272,10 +251,8 @@ RSpec/AnyInstanceOf: - spec/lib/gitlab/metrics/rack_middleware_spec.rb - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb - spec/lib/gitlab/metrics_spec.rb - - spec/lib/gitlab/patch/action_dispatch_journey_formatter_spec.rb - spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb - spec/lib/gitlab/sidekiq_middleware_spec.rb - - spec/lib/gitlab/tracking/destinations/product_analytics_spec.rb - spec/lib/gitlab/tracking/destinations/snowplow_spec.rb - spec/lib/gitlab/tracking_spec.rb - spec/lib/gitlab/usage_data_spec.rb @@ -335,20 +312,17 @@ RSpec/AnyInstanceOf: - spec/requests/git_http_spec.rb - spec/requests/import/gitlab_projects_controller_spec.rb - spec/routing/routing_spec.rb - - spec/serializers/analytics_stage_serializer_spec.rb - spec/serializers/merge_request_poll_cached_widget_entity_spec.rb - spec/serializers/merge_request_poll_widget_entity_spec.rb - spec/services/application_settings/update_service_spec.rb - spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb - spec/services/boards/lists/update_service_spec.rb - spec/services/ci/create_pipeline_service_spec.rb - - spec/services/ci/destroy_expired_job_artifacts_service_spec.rb - spec/services/ci/expire_pipeline_cache_service_spec.rb - spec/services/ci/list_config_variables_service_spec.rb - spec/services/ci/register_job_service_spec.rb - spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb - spec/services/ci/retry_pipeline_service_spec.rb - - spec/services/ci/stop_environments_service_spec.rb - spec/services/clusters/applications/create_service_spec.rb - spec/services/clusters/cleanup/project_namespace_service_spec.rb - spec/services/clusters/cleanup/service_account_service_spec.rb @@ -379,7 +353,6 @@ RSpec/AnyInstanceOf: - spec/services/packages/conan/create_package_file_service_spec.rb - spec/services/packages/nuget/metadata_extraction_service_spec.rb - spec/services/packages/nuget/update_package_from_metadata_service_spec.rb - - spec/services/pages/delete_services_spec.rb - spec/services/post_receive_service_spec.rb - spec/services/projects/after_rename_service_spec.rb - spec/services/projects/container_repository/cleanup_tags_service_spec.rb @@ -448,7 +421,6 @@ RSpec/AnyInstanceOf: - spec/support/shared_examples/uploaders/object_storage_shared_examples.rb - spec/support/shared_examples/workers/authorized_projects_worker_shared_example.rb - spec/support/shared_examples/workers/reactive_cacheable_shared_examples.rb - - spec/support/snowplow.rb - spec/tasks/gitlab/cleanup_rake_spec.rb - spec/tasks/gitlab/container_registry_rake_spec.rb - spec/tasks/gitlab/db_rake_spec.rb @@ -462,9 +434,7 @@ RSpec/AnyInstanceOf: - spec/views/layouts/_head.html.haml_spec.rb - spec/views/projects/artifacts/_artifact.html.haml_spec.rb - spec/workers/archive_trace_worker_spec.rb - - spec/workers/build_coverage_worker_spec.rb - spec/workers/build_hooks_worker_spec.rb - - spec/workers/build_trace_sections_worker_spec.rb - spec/workers/ci/build_schedule_worker_spec.rb - spec/workers/ci/daily_build_group_report_results_worker_spec.rb - spec/workers/cluster_configure_istio_worker_spec.rb @@ -484,7 +454,6 @@ RSpec/AnyInstanceOf: - spec/workers/new_note_worker_spec.rb - spec/workers/object_pool/create_worker_spec.rb - spec/workers/packages/nuget/extraction_worker_spec.rb - - spec/workers/pages_remove_worker_spec.rb - spec/workers/pipeline_hooks_worker_spec.rb - spec/workers/pipeline_process_worker_spec.rb - spec/workers/pipeline_schedule_worker_spec.rb diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 7becad56886..a51ba5e930b 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -871,7 +871,6 @@ RSpec/ContextWording: - 'ee/spec/services/ee/integrations/test/project_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - 'ee/spec/services/ee/issues/close_service_spec.rb' @@ -978,7 +977,6 @@ RSpec/ContextWording: - 'ee/spec/services/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - 'ee/spec/services/milestones/update_service_spec.rb' - - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb' - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'ee/spec/services/namespaces/storage/email_notification_service_spec.rb' - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' @@ -3306,7 +3304,6 @@ RSpec/ContextWording: - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb' - 'spec/services/integrations/propagate_service_spec.rb' - 'spec/services/integrations/test/project_service_spec.rb' - - 'spec/services/issuable/clone/attributes_rewriter_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issue_links/list_service_spec.rb' - 'spec/services/issues/build_service_spec.rb' @@ -3657,7 +3654,6 @@ RSpec/ContextWording: - 'spec/support/shared_examples/models/cluster_application_helm_cert_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_status_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_version_shared_examples.rb' - - 'spec/support/shared_examples/models/clusters/elastic_stack_client_shared.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/composite_id_shared_examples.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index ef8897100e3..b08830bd5a3 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -151,7 +151,6 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/create_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 56b3f48c670..cd73b76b14e 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -88,7 +88,6 @@ RSpec/ExpectInHook: - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' - - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 2f6d390bec2..8330d768794 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -1,11 +1,9 @@ --- RSpec/MultipleMemoizedHelpers: Exclude: - - spec/lib/gitlab/background_migration/populate_finding_uuid_for_vulnerability_feedback_spec.rb - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb - spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb - spec/requests/api/ci/runner/jobs_artifacts_spec.rb - ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb - ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb - ee/spec/services/ee/boards/issues/move_service_spec.rb - - ee/spec/services/security/store_report_service_spec.rb diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 420b51316c3..84e862ff48b 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -85,14 +85,12 @@ RSpec/VerifiedDoubles: - ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb - ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb - ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb - - ee/spec/lib/gitlab/patch/legacy_database_config_spec.rb - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb - ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb - ee/spec/models/approvable_spec.rb - - ee/spec/models/concerns/ee/sha_attribute_spec.rb - ee/spec/models/concerns/geo/verification_state_spec.rb - ee/spec/models/ee/ci/job_artifact_spec.rb - ee/spec/models/ee/user_spec.rb @@ -247,7 +245,6 @@ RSpec/VerifiedDoubles: - qa/spec/support/formatters/allure_metadata_formatter_spec.rb - qa/spec/support/page_error_checker_spec.rb - qa/spec/support/run_spec.rb - - qa/spec/support/shared_examples/scenario_shared_examples.rb - qa/spec/tools/long_running_spec_reporter_spec.rb - spec/benchmarks/banzai_benchmark.rb - spec/bin/feature_flag_spec.rb @@ -377,7 +374,6 @@ RSpec/VerifiedDoubles: - spec/lib/api/helpers_spec.rb - spec/lib/atlassian/jira_connect/client_spec.rb - spec/lib/backup/files_spec.rb - - spec/lib/backup/gitaly_rpc_backup_spec.rb - spec/lib/backup/repositories_spec.rb - spec/lib/banzai/cross_project_reference_spec.rb - spec/lib/banzai/filter/gollum_tags_filter_spec.rb @@ -400,7 +396,6 @@ RSpec/VerifiedDoubles: - spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb - spec/lib/bulk_imports/projects/transformers/project_attributes_transformer_spec.rb - spec/lib/constraints/admin_constrainer_spec.rb - - spec/lib/constraints/feature_constrainer_spec.rb - spec/lib/constraints/group_url_constrainer_spec.rb - spec/lib/constraints/jira_encoded_url_constrainer_spec.rb - spec/lib/constraints/project_url_constrainer_spec.rb @@ -646,7 +641,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb - spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb - spec/lib/gitlab/graphql/batch_key_spec.rb - - spec/lib/gitlab/graphql/find_argument_in_parent_spec.rb - spec/lib/gitlab/graphql/generic_tracing_spec.rb - spec/lib/gitlab/graphql/lazy_spec.rb - spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb @@ -707,7 +701,6 @@ RSpec/VerifiedDoubles: - spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb - spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb - spec/lib/gitlab/metrics/exporter/gc_request_middleware_spec.rb - - spec/lib/gitlab/metrics/exporter/health_checks_middleware_spec.rb - spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb - spec/lib/gitlab/metrics/rack_middleware_spec.rb - spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb @@ -835,7 +828,6 @@ RSpec/VerifiedDoubles: - spec/models/concerns/atomic_internal_id_spec.rb - spec/models/concerns/legacy_bulk_insert_spec.rb - spec/models/concerns/prometheus_adapter_spec.rb - - spec/models/concerns/sha256_attribute_spec.rb - spec/models/concerns/sha_attribute_spec.rb - spec/models/concerns/token_authenticatable_strategies/base_spec.rb - spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb @@ -988,7 +980,6 @@ RSpec/VerifiedDoubles: - spec/services/ide/schemas_config_service_spec.rb - spec/services/import/bitbucket_server_service_spec.rb - spec/services/import/github_service_spec.rb - - spec/services/import/gitlab_projects/create_project_from_remote_file_service_spec.rb - spec/services/issues/create_service_spec.rb - spec/services/issues/related_branches_service_spec.rb - spec/services/jira_connect_subscriptions/create_service_spec.rb @@ -1007,7 +998,6 @@ RSpec/VerifiedDoubles: - spec/services/metrics/users_starred_dashboards/create_service_spec.rb - spec/services/milestones/update_service_spec.rb - spec/services/namespaces/in_product_marketing_emails_service_spec.rb - - spec/services/namespaces/invite_team_email_service_spec.rb - spec/services/notes/create_service_spec.rb - spec/services/notes/render_service_spec.rb - spec/services/notification_service_spec.rb @@ -1030,7 +1020,6 @@ RSpec/VerifiedDoubles: - spec/services/projects/update_service_spec.rb - spec/services/repositories/changelog_service_spec.rb - spec/services/search_service_spec.rb - - spec/services/service_ping/build_payload_service_spec.rb - spec/services/service_ping/submit_service_ping_service_spec.rb - spec/services/snippets/update_repository_storage_service_spec.rb - spec/services/spam/akismet_mark_as_spam_service_spec.rb diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index f6bff468c76..e5ce2576f8c 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -16,7 +16,6 @@ Style/ExplicitBlockArgument: - 'app/models/merge_request.rb' - 'app/models/snippet_repository.rb' - 'app/services/import_export_clean_up_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/each_shard_worker.rb' - 'db/migrate/20210629031900_associate_existing_dast_builds_with_variables.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index a9065bb5932..caa293b31ae 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -165,8 +165,6 @@ Style/FormatString: - 'app/services/metrics/dashboard/update_dashboard_service.rb' - 'app/services/milestones/promote_service.rb' - 'app/services/personal_access_tokens/revoke_service.rb' - - 'app/services/pod_logs/elasticsearch_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/projects/cleanup_service.rb' - 'app/services/projects/create_from_template_service.rb' - 'app/services/projects/import_service.rb' @@ -232,8 +230,6 @@ Style/FormatString: - 'ee/app/services/incident_management/escalation_policies/base_service.rb' - 'ee/app/services/issues/build_from_vulnerability_service.rb' - 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb' - - 'ee/app/services/namespaces/check_excess_storage_size_service.rb' - - 'ee/app/services/namespaces/check_storage_size_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/timebox_report_service.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 845a59a2a14..1dfedcc91c0 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -307,7 +307,6 @@ Style/IfUnlessModifier: - 'app/services/import/github_service.rb' - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/issuable/bulk_update_service.rb' - - 'app/services/issuable/clone/attributes_rewriter.rb' - 'app/services/issuable/common_system_notes_service.rb' - 'app/services/issuable_base_service.rb' - 'app/services/issuable_links/create_service.rb' @@ -356,7 +355,6 @@ Style/IfUnlessModifier: - 'app/services/packages/pypi/create_package_service.rb' - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - - 'app/services/pod_logs/kubernetes_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' - 'app/services/projects/container_repository/third_party/delete_tags_service.rb' @@ -936,7 +934,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/diff/formatters/base_formatter.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - - 'lib/gitlab/elasticsearch/logs/lines.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/repository_push.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index cd8a41669bb..ecf7a5cf05e 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -20,7 +20,6 @@ Style/PercentLiteralDelimiters: - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/projects/logs_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - 'app/controllers/projects/product_analytics_controller.rb' - 'app/controllers/projects/service_desk_controller.rb' diff --git a/Gemfile b/Gemfile index 1b24400dd13..722324d812e 100644 --- a/Gemfile +++ b/Gemfile @@ -342,7 +342,7 @@ gem 'method_source', '~> 1.0', require: false gem 'webrick', '~> 1.6.1', require: false gem 'prometheus-client-mmap', '~> 0.16', require: 'prometheus/client' -gem 'warning', '~> 1.2.0' +gem 'warning', '~> 1.3.0' group :development do gem 'lefthook', '~> 1.0.0', require: false diff --git a/Gemfile.lock b/Gemfile.lock index a9c0338002a..379f4a5d1cf 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1431,7 +1431,7 @@ GEM vmstat (2.3.0) warden (1.2.8) rack (>= 2.0.6) - warning (1.2.0) + warning (1.3.0) webauthn (2.3.0) android_key_attestation (~> 0.3.0) awrence (~> 1.1) @@ -1756,7 +1756,7 @@ DEPENDENCIES version_sorter (~> 2.2.4) view_component (~> 2.50.0) vmstat (~> 2.3.0) - warning (~> 1.2.0) + warning (~> 1.3.0) webauthn (~> 2.3) webmock (~> 3.9.1) webrick (~> 1.6.1) diff --git a/app/assets/javascripts/content_editor/services/hast_to_prosemirror_converter.js b/app/assets/javascripts/content_editor/services/hast_to_prosemirror_converter.js index ad9419699c8..6544cd192f9 100644 --- a/app/assets/javascripts/content_editor/services/hast_to_prosemirror_converter.js +++ b/app/assets/javascripts/content_editor/services/hast_to_prosemirror_converter.js @@ -454,11 +454,14 @@ const wrapInlineElements = (nodes, wrappableTags) => nodes.reduce((children, child) => { const previous = children[children.length - 1]; - if (child.type !== 'text' && !wrappableTags.includes(child.tagName)) { + if ( + child.type === 'comment' || + (child.type !== 'text' && !wrappableTags.includes(child.tagName)) + ) { return [...children, child]; } - const wrapperExists = previous?.properties.wrapper; + const wrapperExists = previous?.properties?.wrapper; if (wrapperExists) { const wrapper = previous; diff --git a/app/assets/javascripts/content_editor/services/remark_markdown_deserializer.js b/app/assets/javascripts/content_editor/services/remark_markdown_deserializer.js index 9bf130c454e..b3815262639 100644 --- a/app/assets/javascripts/content_editor/services/remark_markdown_deserializer.js +++ b/app/assets/javascripts/content_editor/services/remark_markdown_deserializer.js @@ -5,7 +5,7 @@ import { createProseMirrorDocFromMdastTree } from './hast_to_prosemirror_convert const wrappableTags = ['img', 'br', 'code', 'i', 'em', 'b', 'strong', 'a', 'strike', 's', 'del']; const isTaskItem = (hastNode) => { - const { className } = hastNode.properties; + const className = hastNode.properties?.className; return ( hastNode.tagName === 'li' && Array.isArray(className) && className.includes('task-list-item') @@ -23,16 +23,16 @@ const factorySpecs = { listItem: { type: 'block', wrapInParagraph: true, - selector: (hastNode) => hastNode.tagName === 'li' && !hastNode.properties.className, + selector: (hastNode) => hastNode.tagName === 'li' && !hastNode.properties?.className, processText: (text) => text.trimRight(), }, orderedList: { type: 'block', - selector: (hastNode) => hastNode.tagName === 'ol' && !hastNode.properties.className, + selector: (hastNode) => hastNode.tagName === 'ol' && !hastNode.properties?.className, }, bulletList: { type: 'block', - selector: (hastNode) => hastNode.tagName === 'ul' && !hastNode.properties.className, + selector: (hastNode) => hastNode.tagName === 'ul' && !hastNode.properties?.className, }, heading: { type: 'block', @@ -62,7 +62,7 @@ const factorySpecs = { taskList: { type: 'block', selector: (hastNode) => { - const { className } = hastNode.properties; + const className = hastNode.properties?.className; return ( ['ul', 'ol'].includes(hastNode.tagName) && @@ -165,6 +165,14 @@ const factorySpecs = { type: 'mark', selector: (hastNode) => ['strike', 's', 'del'].includes(hastNode.tagName), }, + /* TODO + * Implement proper editing support for HTML comments in the Content Editor + * https://gitlab.com/gitlab-org/gitlab/-/issues/342173 + */ + comment: { + type: 'ignore', + selector: (hastNode) => hastNode.type === 'comment', + }, }; export default () => { diff --git a/app/assets/javascripts/notes/components/comment_form.vue b/app/assets/javascripts/notes/components/comment_form.vue index e7ac27c5e3e..bd5945a951b 100644 --- a/app/assets/javascripts/notes/components/comment_form.vue +++ b/app/assets/javascripts/notes/components/comment_form.vue @@ -172,9 +172,6 @@ export default { trackingLabel() { return slugifyWithUnderscore(`${this.commentButtonTitle} button`); }, - internalNotesEnabled() { - return Boolean(this.glFeatures.confidentialNotes); - }, disableSubmitButton() { return this.note.length === 0 || this.isSubmitting; }, @@ -414,7 +411,7 @@ export default {