Resolve annoying deprecation warnings
DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? ...
This commit is contained in:
parent
5db5e50927
commit
5e0a288e7f
|
@ -21,6 +21,6 @@ describe Admin::AbuseReportsController, '(JavaScript fixtures)', type: :controll
|
||||||
it 'abuse_reports/abuse_reports_list.html' do
|
it 'abuse_reports/abuse_reports_list.html' do
|
||||||
get :index
|
get :index
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -23,6 +23,6 @@ describe Admin::UsersController, '(JavaScript fixtures)', type: :controller do
|
||||||
|
|
||||||
get :new
|
get :new
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -28,6 +28,6 @@ describe Admin::ApplicationSettingsController, '(JavaScript fixtures)', type: :c
|
||||||
|
|
||||||
get :show
|
get :show
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -34,6 +34,6 @@ describe Projects::AutocompleteSourcesController, '(JavaScript fixtures)', type:
|
||||||
type_id: issue.id
|
type_id: issue.id
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -29,6 +29,6 @@ describe Projects::BlobController, '(JavaScript fixtures)', type: :controller do
|
||||||
id: 'add-ipython-files/files/ipython/basic.ipynb'
|
id: 'add-ipython-files/files/ipython/basic.ipynb'
|
||||||
})
|
})
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -23,6 +23,6 @@ describe Projects::BoardsController, '(JavaScript fixtures)', type: :controller
|
||||||
project_id: project
|
project_id: project
|
||||||
})
|
})
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -27,6 +27,6 @@ describe Projects::BranchesController, '(JavaScript fixtures)', type: :controlle
|
||||||
project_id: project
|
project_id: project
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -29,6 +29,6 @@ describe Projects::ClustersController, '(JavaScript fixtures)', type: :controlle
|
||||||
id: cluster
|
id: cluster
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -28,6 +28,6 @@ describe Projects::CommitController, '(JavaScript fixtures)', type: :controller
|
||||||
|
|
||||||
get :show, params: params
|
get :show, params: params
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -38,6 +38,6 @@ describe Projects::DeployKeysController, '(JavaScript fixtures)', type: :control
|
||||||
project_id: project
|
project_id: project
|
||||||
}, format: :json
|
}, format: :json
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -21,7 +21,7 @@ describe 'Groups (JavaScript fixtures)', type: :controller do
|
||||||
it 'groups/edit.html' do
|
it 'groups/edit.html' do
|
||||||
get :edit, params: { id: group }
|
get :edit, params: { id: group }
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -29,7 +29,7 @@ describe 'Groups (JavaScript fixtures)', type: :controller do
|
||||||
it 'groups/ci_cd_settings.html' do
|
it 'groups/ci_cd_settings.html' do
|
||||||
get :show, params: { group_id: group }
|
get :show, params: { group_id: group }
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -48,7 +48,7 @@ describe Projects::IssuesController, '(JavaScript fixtures)', type: :controller
|
||||||
project_id: project
|
project_id: project
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
@ -60,7 +60,7 @@ describe Projects::IssuesController, '(JavaScript fixtures)', type: :controller
|
||||||
id: issue.to_param
|
id: issue.to_param
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -117,6 +117,6 @@ describe API::Issues, '(JavaScript fixtures)', type: :request do
|
||||||
|
|
||||||
get_related_merge_requests(project.id, issue.iid, user)
|
get_related_merge_requests(project.id, issue.iid, user)
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -39,7 +39,7 @@ describe Projects::JobsController, '(JavaScript fixtures)', type: :controller do
|
||||||
id: build_with_artifacts.to_param
|
id: build_with_artifacts.to_param
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'jobs/delayed.json' do
|
it 'jobs/delayed.json' do
|
||||||
|
@ -49,6 +49,6 @@ describe Projects::JobsController, '(JavaScript fixtures)', type: :controller do
|
||||||
id: delayed_job.to_param
|
id: delayed_job.to_param
|
||||||
}, format: :json
|
}, format: :json
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -35,7 +35,7 @@ describe 'Labels (JavaScript fixtures)' do
|
||||||
group_id: group
|
group_id: group
|
||||||
}, format: 'json'
|
}, format: 'json'
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -52,7 +52,7 @@ describe 'Labels (JavaScript fixtures)' do
|
||||||
project_id: project
|
project_id: project
|
||||||
}, format: 'json'
|
}, format: 'json'
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -129,6 +129,6 @@ describe Projects::MergeRequestsController, '(JavaScript fixtures)', type: :cont
|
||||||
id: merge_request.to_param
|
id: merge_request.to_param
|
||||||
}, format: :html
|
}, format: :html
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -65,6 +65,6 @@ describe Projects::MergeRequests::DiffsController, '(JavaScript fixtures)', type
|
||||||
**extra_params
|
**extra_params
|
||||||
}, format: :json
|
}, format: :json
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -28,7 +28,7 @@ describe Projects::PipelineSchedulesController, '(JavaScript fixtures)', type: :
|
||||||
id: pipeline_schedule.id
|
id: pipeline_schedule.id
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'pipeline_schedules/edit_with_variables.html' do
|
it 'pipeline_schedules/edit_with_variables.html' do
|
||||||
|
@ -38,6 +38,6 @@ describe Projects::PipelineSchedulesController, '(JavaScript fixtures)', type: :
|
||||||
id: pipeline_schedule_populated.id
|
id: pipeline_schedule_populated.id
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -29,6 +29,6 @@ describe Projects::PipelinesController, '(JavaScript fixtures)', type: :controll
|
||||||
project_id: project
|
project_id: project
|
||||||
}, format: :json
|
}, format: :json
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -34,7 +34,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
|
||||||
id: project
|
id: project
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'projects/overview.html' do
|
it 'projects/overview.html' do
|
||||||
|
@ -43,7 +43,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
|
||||||
id: project_with_repo
|
id: project_with_repo
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'projects/edit.html' do
|
it 'projects/edit.html' do
|
||||||
|
@ -52,7 +52,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
|
||||||
id: project
|
id: project
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -63,7 +63,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
|
||||||
project_id: project
|
project_id: project
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'projects/ci_cd_settings_with_variables.html' do
|
it 'projects/ci_cd_settings_with_variables.html' do
|
||||||
|
@ -75,7 +75,7 @@ describe 'Projects (JavaScript fixtures)', type: :controller do
|
||||||
project_id: project_variable_populated
|
project_id: project_variable_populated
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -29,6 +29,6 @@ describe Projects::ServicesController, '(JavaScript fixtures)', type: :controlle
|
||||||
id: service.to_param
|
id: service.to_param
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -12,6 +12,6 @@ describe SearchController, '(JavaScript fixtures)', type: :controller do
|
||||||
it 'search/show.html' do
|
it 'search/show.html' do
|
||||||
get :show
|
get :show
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -29,6 +29,6 @@ describe Projects::ServicesController, '(JavaScript fixtures)', type: :controlle
|
||||||
id: service.to_param
|
id: service.to_param
|
||||||
}
|
}
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -19,7 +19,7 @@ describe 'Sessions (JavaScript fixtures)' do
|
||||||
it 'sessions/new.html' do
|
it 'sessions/new.html' do
|
||||||
get :new
|
get :new
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -28,6 +28,6 @@ describe SnippetsController, '(JavaScript fixtures)', type: :controller do
|
||||||
|
|
||||||
get(:show, params: { id: snippet.to_param })
|
get(:show, params: { id: snippet.to_param })
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -29,7 +29,7 @@ describe 'Todos (JavaScript fixtures)' do
|
||||||
it 'todos/todos.html' do
|
it 'todos/todos.html' do
|
||||||
get :index
|
get :index
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -48,7 +48,7 @@ describe 'Todos (JavaScript fixtures)' do
|
||||||
issuable_id: issue_2.id
|
issuable_id: issue_2.id
|
||||||
}, format: 'json'
|
}, format: 'json'
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -23,7 +23,7 @@ context 'U2F' do
|
||||||
|
|
||||||
post :create, params: { user: { login: user.username, password: user.password } }
|
post :create, params: { user: { login: user.username, password: user.password } }
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -38,7 +38,7 @@ context 'U2F' do
|
||||||
it 'u2f/register.html' do
|
it 'u2f/register.html' do
|
||||||
get :show
|
get :show
|
||||||
|
|
||||||
expect(response).to be_success
|
expect(response).to be_successful
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in New Issue