Resolve "Bug: When creating an account with invalid characters the error is "Username already taken" not "Invalid characters used""

This commit is contained in:
Jan 2018-06-13 10:42:40 +00:00 committed by Rémy Coutable
parent 115ab79b70
commit 5e2b8ab8d7
2 changed files with 9 additions and 5 deletions

View file

@ -62,13 +62,13 @@ export default class UsernameValidator {
return this.setPendingState();
}
if (!this.state.available) {
return this.setUnavailableState();
}
if (!this.state.valid) {
return this.setInvalidState();
}
if (!this.state.available) {
return this.setUnavailableState();
}
}
interceptInvalid(event) {
@ -89,7 +89,6 @@ export default class UsernameValidator {
setAvailabilityState(usernameTaken) {
if (usernameTaken) {
this.state.valid = false;
this.state.available = false;
} else {
this.state.available = true;

View file

@ -0,0 +1,5 @@
---
title: 'Fix username validation order on signup, resolves #45575'
merge_request: 19610
author: Jan Beckmann
type: fixed