Improve specs
This commit is contained in:
parent
2b0b53cddd
commit
5ec1c140d9
3 changed files with 18 additions and 9 deletions
|
@ -152,7 +152,7 @@ describe "Pipelines" do
|
|||
end
|
||||
end
|
||||
|
||||
describe 'GET /:project/pipelines/stage?name=stage' do
|
||||
describe 'GET /:project/pipelines/stage.json?name=stage' do
|
||||
let!(:pipeline) do
|
||||
create(:ci_empty_pipeline, project: project, ref: 'master',
|
||||
status: 'running')
|
||||
|
@ -168,7 +168,10 @@ describe "Pipelines" do
|
|||
project.namespace, project, pipeline, format: :json, stage: 'build')
|
||||
end
|
||||
|
||||
it { expect(page).to have_http_status(:ok) }
|
||||
it do
|
||||
expect(page).to have_http_status(:ok)
|
||||
expect(JSON.parse(page.source)).to include("html")
|
||||
end
|
||||
end
|
||||
|
||||
context 'when accessing unknown stage' do
|
||||
|
|
|
@ -179,15 +179,19 @@ describe Ci::Pipeline, models: true do
|
|||
subject { pipeline.stage('test') }
|
||||
|
||||
context 'with status in stage' do
|
||||
let!(:status) { create(:commit_status, pipeline: pipeline, stage: 'test') }
|
||||
|
||||
it 'return stage object' do
|
||||
is_expected.to be_a(Ci::Stage)
|
||||
before do
|
||||
create(:commit_status, pipeline: pipeline, stage: 'test')
|
||||
end
|
||||
|
||||
it { expect(subject).to be_a(Ci::Stage) }
|
||||
it { expect(subject.name).to eq('stage') }
|
||||
it { expect(subject.statues).not_to be_empty }
|
||||
end
|
||||
|
||||
context 'without status in stage' do
|
||||
let!(:status) { create(:commit_status, pipeline: pipeline, stage: 'build') }
|
||||
before do
|
||||
create(:commit_status, pipeline: pipeline, stage: 'build')
|
||||
end
|
||||
|
||||
it 'return stage object' do
|
||||
is_expected.to be_nil
|
||||
|
|
|
@ -29,8 +29,10 @@ describe Ci::Stage, models: true do
|
|||
end
|
||||
|
||||
describe '#statuses_count' do
|
||||
let!(:stage_build) { create_job(:ci_build) }
|
||||
let!(:other_build) { create_job(:ci_build, stage: 'other stage') }
|
||||
before do
|
||||
create_job(:ci_build) }
|
||||
create_job(:ci_build, stage: 'other stage')
|
||||
end
|
||||
|
||||
subject { stage.statuses_count }
|
||||
|
||||
|
|
Loading…
Reference in a new issue