kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'qa-dd-improve-job-querying-successful' into 'master'

Browse source 
Make the job#successful? method wait by refreshing

See merge request gitlab-org/gitlab-ce!26344
This commit is contained in:
Dan Davison 2019-03-27 04:12:50 +00:00
commit 5f0908bead
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
qa/qa/page/project/job/show.rb
View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
module QA::Page module QA::Page
module Project::Job module Project::Job
class Show < QA::Page::Base class Show < QA::Page::Base
@ -31,7 +33,9 @@ module QA::Page
private private
def loaded?(wait: 60) def loaded?(wait: 60)
has_element?(:build_trace, wait: wait) wait(reload: true, max: wait, interval: 1) do
has_element?(:build_trace, wait: 1)
end
end end
def completed?(timeout: 60) def completed?(timeout: 60)