replace `is_legacy_group_milestone?` with `legacy_group_milestone?`
This commit is contained in:
parent
48d3e5fac6
commit
5f72aaa303
|
@ -35,13 +35,13 @@ class Groups::MilestonesController < Groups::ApplicationController
|
|||
end
|
||||
|
||||
def edit
|
||||
render_404 if @milestone.is_legacy_group_milestone?
|
||||
render_404 if @milestone.legacy_group_milestone?
|
||||
end
|
||||
|
||||
def update
|
||||
# Keep this compatible with legacy group milestones where we have to update
|
||||
# all projects milestones states at once.
|
||||
if @milestone.is_legacy_group_milestone?
|
||||
if @milestone.legacy_group_milestone?
|
||||
update_params = milestone_params.select { |key| key == "state_event" }
|
||||
milestones = @milestone.milestones
|
||||
else
|
||||
|
@ -67,7 +67,7 @@ class Groups::MilestonesController < Groups::ApplicationController
|
|||
end
|
||||
|
||||
def milestone_path
|
||||
if @milestone.is_legacy_group_milestone?
|
||||
if @milestone.legacy_group_milestone?
|
||||
group_milestone_path(group, @milestone.safe_title, title: @milestone.title)
|
||||
else
|
||||
group_milestone_path(group, @milestone.iid)
|
||||
|
|
|
@ -164,7 +164,7 @@ module MilestonesHelper
|
|||
def group_milestone_route(milestone, params = {})
|
||||
params = nil if params.empty?
|
||||
|
||||
if milestone.is_legacy_group_milestone?
|
||||
if milestone.legacy_group_milestone?
|
||||
group_milestone_path(@group, milestone.safe_title, title: milestone.title, milestone: params)
|
||||
else
|
||||
group_milestone_path(@group, milestone.iid, milestone: params)
|
||||
|
|
|
@ -78,7 +78,7 @@ module Milestoneish
|
|||
false
|
||||
end
|
||||
|
||||
def is_legacy_group_milestone?
|
||||
def legacy_group_milestone?
|
||||
false
|
||||
end
|
||||
|
||||
|
|
|
@ -17,7 +17,7 @@ class GroupMilestone < GlobalMilestone
|
|||
{ group_id: group.id }
|
||||
end
|
||||
|
||||
def is_legacy_group_milestone?
|
||||
def legacy_group_milestone?
|
||||
true
|
||||
end
|
||||
end
|
||||
|
|
|
@ -1,4 +1,4 @@
|
|||
= render "header_title"
|
||||
= render 'shared/milestones/top', milestone: @milestone, group: @group
|
||||
= render 'shared/milestones/tabs', milestone: @milestone, show_project_name: true if @milestone.is_legacy_group_milestone?
|
||||
= render 'shared/milestones/tabs', milestone: @milestone, show_project_name: true if @milestone.legacy_group_milestone?
|
||||
= render 'shared/milestones/sidebar', milestone: @milestone, affix_offset: 102
|
||||
|
|
|
@ -21,7 +21,7 @@
|
|||
- if milestone.is_a?(GlobalMilestone) || milestone.is_group_milestone?
|
||||
.row
|
||||
.col-sm-6
|
||||
- if milestone.is_legacy_group_milestone?
|
||||
- if milestone.legacy_group_milestone?
|
||||
.expiration= render('shared/milestone_expired', milestone: milestone)
|
||||
.projects
|
||||
- milestone.milestones.each do |milestone|
|
||||
|
|
|
@ -44,7 +44,7 @@
|
|||
- close_msg = group ? 'You may close the milestone now.' : 'Navigate to the project to close the milestone.'
|
||||
%span All issues for this milestone are closed. #{close_msg}
|
||||
|
||||
- if @milestone.is_legacy_group_milestone? || @milestone.is_dashboard_milestone?
|
||||
- if @milestone.legacy_group_milestone? || @milestone.is_dashboard_milestone?
|
||||
.table-holder
|
||||
%table.table
|
||||
%thead
|
||||
|
|
Loading…
Reference in New Issue