kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use expect { }.to change { }

Browse source 
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8664#note_23427575
This commit is contained in:
Lin Jen-Shin 2017-02-15 20:21:51 +08:00
parent 3856a3daa1
commit 60288d6c62
2 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
spec/controllers/admin/runners_controller_spec.rb
View file

@ -31,16 +31,16 @@ describe Admin::RunnersController do
describe '#update' do
it 'updates the runner and ticks the queue' do
old_tick = runner.ensure_runner_queue_value
new_desc = runner.description.swapcase
post :update, id: runner.id, runner: { description: new_desc }
expect do
post :update, id: runner.id, runner: { description: new_desc }
end.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_http_status(302)
expect(runner.description).to eq(new_desc)
expect(runner.ensure_runner_queue_value).not_to eq(old_tick)
end
end
@ -55,31 +55,31 @@ describe Admin::RunnersController do
describe '#resume' do
it 'marks the runner as active and ticks the queue' do
old_tick = runner.ensure_runner_queue_value
runner.update(active: false)
post :resume, id: runner.id
expect do
post :resume, id: runner.id
end.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_http_status(302)
expect(runner.active).to eq(true)
expect(runner.ensure_runner_queue_value).not_to eq(old_tick)
end
end
describe '#pause' do
it 'marks the runner as inactive and ticks the queue' do
old_tick = runner.ensure_runner_queue_value
runner.update(active: true)
post :pause, id: runner.id
expect do
post :pause, id: runner.id
end.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_http_status(302)
expect(runner.active).to eq(false)
expect(runner.ensure_runner_queue_value).not_to eq(old_tick)
end
end
end

18
spec/controllers/projects/runners_controller_spec.rb
View file

@ -21,16 +21,16 @@ describe Projects::RunnersController do
describe '#update' do
it 'updates the runner and ticks the queue' do
old_tick = runner.ensure_runner_queue_value
new_desc = runner.description.swapcase
post :update, params.merge(runner: { description: new_desc } )
expect do
post :update, params.merge(runner: { description: new_desc } )
end.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_http_status(302)
expect(runner.description).to eq(new_desc)
expect(runner.ensure_runner_queue_value).not_to eq(old_tick)
end
end
@ -45,31 +45,31 @@ describe Projects::RunnersController do
describe '#resume' do
it 'marks the runner as active and ticks the queue' do
old_tick = runner.ensure_runner_queue_value
runner.update(active: false)
post :resume, params
expect do
post :resume, params
end.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_http_status(302)
expect(runner.active).to eq(true)
expect(runner.ensure_runner_queue_value).not_to eq(old_tick)
end
end
describe '#pause' do
it 'marks the runner as inactive and ticks the queue' do
old_tick = runner.ensure_runner_queue_value
runner.update(active: true)
post :pause, params
expect do
post :pause, params
end.to change { runner.ensure_runner_queue_value }
runner.reload
expect(response).to have_http_status(302)
expect(runner.active).to eq(false)
expect(runner.ensure_runner_queue_value).not_to eq(old_tick)
end
end
end