From 6028f9eecfad1190e99c830b3367b7ccb9fb5c81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matija=20=C4=8Cupi=C4=87?= Date: Mon, 22 Jan 2018 20:37:02 +0100 Subject: [PATCH] Refactor auto_devops_domain setting specs --- spec/models/application_setting_spec.rb | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/spec/models/application_setting_spec.rb b/spec/models/application_setting_spec.rb index 0d7b98229a4..ae2d34750a7 100644 --- a/spec/models/application_setting_spec.rb +++ b/spec/models/application_setting_spec.rb @@ -120,6 +120,12 @@ describe ApplicationSetting do setting.update(auto_devops_enabled: true) end + it 'can be blank' do + setting.update(auto_devops_domain: '') + + expect(setting).to be_valid + end + context 'with a valid value' do before do setting.update(auto_devops_domain: 'domain.com') @@ -140,18 +146,6 @@ describe ApplicationSetting do end end end - - context 'when auto_devops_enabled? is false' do - before do - setting.update(auto_devops_enabled: false) - end - - it 'can be blank' do - setting.update(auto_devops_domain: '') - - expect(setting).to be_valid - end - end end context 'circuitbreaker settings' do