Fix reviewer roulette when no-one is in a category
This would return `people.size` before, when it should return `nil`.
This commit is contained in:
parent
0ed961a81a
commit
60525148e7
|
@ -57,10 +57,12 @@ def spin_for_person(people, random:)
|
||||||
people.size.times do
|
people.size.times do
|
||||||
person = people.sample(random: random)
|
person = people.sample(random: random)
|
||||||
|
|
||||||
return person unless out_of_office?(person)
|
break person unless out_of_office?(person)
|
||||||
|
|
||||||
people -= [person]
|
people -= [person]
|
||||||
end
|
end
|
||||||
|
|
||||||
|
person
|
||||||
end
|
end
|
||||||
|
|
||||||
def out_of_office?(person)
|
def out_of_office?(person)
|
||||||
|
|
Loading…
Reference in New Issue