Fix a bug and a test.
This commit is contained in:
parent
e39b3fe3c5
commit
6073b281aa
1 changed files with 6 additions and 4 deletions
|
@ -64,8 +64,9 @@
|
|||
discussionIdsInScope = discussionIdsForElements($(discussionsSelector));
|
||||
|
||||
let unresolvedDiscussionCount = 0;
|
||||
for (const discussionId of discussionIdsInScope) {
|
||||
const discussion = discussions[discussionId];
|
||||
|
||||
for (let i = 0; i < discussionIdsInScope.length; i++) {
|
||||
const discussionId = discussionIdsInScope[i];
|
||||
if (discussion && !discussion.isResolved()) {
|
||||
unresolvedDiscussionCount++;
|
||||
}
|
||||
|
@ -104,7 +105,8 @@
|
|||
}
|
||||
|
||||
let currentDiscussionFound = false;
|
||||
for (const discussionId of discussionIdsInScope) {
|
||||
for (let i = 0; i < discussionIdsInScope.length; i++) {
|
||||
const discussionId = discussionIdsInScope[i];
|
||||
const discussion = discussions[discussionId];
|
||||
|
||||
if (!discussion) {
|
||||
|
@ -177,7 +179,7 @@
|
|||
|
||||
// If the next discussion is closed, toggle it open.
|
||||
if ($target.find(".js-toggle-content").attr('style') == "display: none;") {
|
||||
$target.find('i').toggleClass('fa fa-chevron-down').toggleClass('fa fa-chevron-up');
|
||||
$target.find('.js-toggle-button i').toggleClass('fa fa-chevron-down').toggleClass('fa fa-chevron-up');
|
||||
$target.find(".js-toggle-content").toggle();
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue