From 60a260df4186ab0fe08352d1eb957b34ebdeb7c2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 26 Jul 2022 15:10:26 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- Gemfile | 2 +- Gemfile.lock | 4 +- .../notes/components/note_actions.vue | 2 +- .../components/added_commit_message.vue | 43 +-- .../components/mr_widget_related_links.vue | 34 +- .../components/mr_widget_status_icon.vue | 20 +- .../components/states/commit_edit.vue | 8 +- .../components/states/mr_widget_archived.vue | 4 +- .../states/mr_widget_auto_merge_enabled.vue | 32 -- .../components/states/mr_widget_checking.vue | 4 +- .../components/states/mr_widget_closed.vue | 9 - .../components/states/mr_widget_conflicts.vue | 12 +- .../components/states/mr_widget_merged.vue | 43 +-- .../components/states/mr_widget_merging.vue | 10 - .../states/mr_widget_missing_branch.vue | 8 +- .../states/mr_widget_pipeline_blocked.vue | 2 +- .../components/states/mr_widget_rebase.vue | 33 +- .../components/states/pipeline_failed.vue | 4 +- .../components/states/ready_to_merge.vue | 346 ++++++------------ .../components/states/sha_mismatch.vue | 5 +- .../components/states/squash_before_merge.vue | 9 +- .../states/unresolved_discussions.vue | 16 +- .../components/states/work_in_progress.vue | 5 +- .../mixins/ready_to_merge.js | 7 - .../mr_widget_options.vue | 33 +- .../stores/get_state_key.js | 2 - .../projects/merge_requests_controller.rb | 1 - app/serializers/issue_entity.rb | 4 + app/views/projects/pages/_use.html.haml | 5 +- app/views/shared/issuable/_form.html.haml | 2 +- app/workers/concerns/waitable_worker.rb | 6 +- ..._async_project_authorizations_refresh.yml} | 12 +- .../package_information/supported_os.md | 2 +- doc/ci/pipeline_editor/index.md | 18 + .../documentation/restful_api_styleguide.md | 3 + .../documentation/site_architecture/index.md | 4 +- lib/gitlab/memory/reports_daemon.rb | 4 +- locale/gitlab.pot | 45 --- qa/qa/page/merge_request/show.rb | 1 - .../user_merges_merge_request_spec.rb | 21 -- .../notes/components/note_actions_spec.js | 29 +- .../components/added_commit_message_spec.js | 5 - .../components/mr_widget_status_icon_spec.js | 17 - .../mr_widget_auto_merge_enabled_spec.js.snap | 56 --- .../mr_widget_pipeline_failed_spec.js.snap | 4 +- .../states/mr_widget_archived_spec.js | 5 - .../mr_widget_auto_merge_enabled_spec.js | 104 ------ .../states/mr_widget_checking_spec.js | 4 - .../states/mr_widget_closed_spec.js | 24 -- .../states/mr_widget_failed_to_merge_spec.js | 2 - .../states/mr_widget_merged_spec.js | 57 +-- .../states/mr_widget_merging_spec.js | 13 - .../states/mr_widget_pipeline_failed_spec.js | 7 - .../states/mr_widget_ready_to_merge_spec.js | 135 ++----- .../components/states/mr_widget_wip_spec.js | 2 - .../vue_mr_widget/mr_widget_options_spec.js | 76 +--- .../stores/get_state_key_spec.js | 22 -- spec/lib/gitlab/git_access_spec.rb | 10 - spec/lib/gitlab/memory/reports_daemon_spec.rb | 4 +- spec/serializers/issue_entity_spec.rb | 7 + spec/services/ci/register_job_service_spec.rb | 16 +- .../reload_diffs_service_spec.rb | 5 +- spec/spec_helper.rb | 1 + spec/support/helpers/stub_member.rb | 8 + spec/support/helpers/stubbed_member.rb | 64 ++++ spec/workers/concerns/waitable_worker_spec.rb | 36 +- 66 files changed, 383 insertions(+), 1155 deletions(-) rename config/feature_flags/development/{restructured_mr_widget.yml => always_async_project_authorizations_refresh.yml} (52%) create mode 100644 spec/support/helpers/stub_member.rb create mode 100644 spec/support/helpers/stubbed_member.rb diff --git a/Gemfile b/Gemfile index 991d84d582e..1883cf53394 100644 --- a/Gemfile +++ b/Gemfile @@ -536,7 +536,7 @@ gem 'valid_email', '~> 0.1' # JSON gem 'json', '~> 2.5.1' gem 'json_schemer', '~> 0.2.18' -gem 'oj', '~> 3.13.17' +gem 'oj', '~> 3.13.18' gem 'multi_json', '~> 1.14.1' gem 'yajl-ruby', '~> 1.4.1', require: 'yajl' diff --git a/Gemfile.lock b/Gemfile.lock index d8c3b881ac2..c32c8a6d2a7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -869,7 +869,7 @@ GEM plist (~> 3.1) train-core wmi-lite (~> 1.0) - oj (3.13.17) + oj (3.13.18) omniauth (1.9.1) hashie (>= 3.4.6) rack (>= 1.6.2, < 3) @@ -1637,7 +1637,7 @@ DEPENDENCIES oauth2 (~> 2.0) octokit (~> 4.15) ohai (~> 16.10) - oj (~> 3.13.17) + oj (~> 3.13.18) omniauth (~> 1.8) omniauth-alicloud (~> 1.0.1) omniauth-atlassian-oauth2 (~> 0.2.0) diff --git a/app/assets/javascripts/notes/components/note_actions.vue b/app/assets/javascripts/notes/components/note_actions.vue index 10e3f57a56d..c7f293a219a 100644 --- a/app/assets/javascripts/notes/components/note_actions.vue +++ b/app/assets/javascripts/notes/components/note_actions.vue @@ -170,7 +170,7 @@ export default { return this.targetType === 'issue'; }, canAssign() { - return this.getNoteableData.current_user?.can_update && this.isIssue; + return this.getNoteableData.current_user?.can_set_issue_metadata && this.isIssue; }, displayAuthorBadgeText() { return sprintf(__('This user is the author of this %{noteable}.'), { diff --git a/app/assets/javascripts/vue_merge_request_widget/components/added_commit_message.vue b/app/assets/javascripts/vue_merge_request_widget/components/added_commit_message.vue index 437d035fbf5..266f1fb594b 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/added_commit_message.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/added_commit_message.vue @@ -52,31 +52,20 @@ export default { return n__('%d commit', '%d commits', this.isSquashEnabled ? 1 : this.commitsCount); }, message() { - if (this.glFeatures.restructuredMrWidget) { - if (this.state === 'closed') { - return s__('mrWidgetCommitsAdded|The changes were not merged into %{targetBranch}.'); - } else if (this.isMerged) { - return s__( - 'mrWidgetCommitsAdded|Changes merged into %{targetBranch} with %{mergeCommitSha}%{squashedCommits}.', - ); - } - - return this.isFastForwardEnabled - ? s__('mrWidgetCommitsAdded|%{commitCount} will be added to %{targetBranch}.') - : s__( - 'mrWidgetCommitsAdded|%{commitCount} and %{mergeCommitCount} will be added to %{targetBranch}%{squashedCommits}.', - ); + if (this.state === 'closed') { + return s__('mrWidgetCommitsAdded|The changes were not merged into %{targetBranch}.'); + } else if (this.isMerged) { + return s__( + 'mrWidgetCommitsAdded|Changes merged into %{targetBranch} with %{mergeCommitSha}%{squashedCommits}.', + ); } return this.isFastForwardEnabled - ? s__('mrWidgetCommitsAdded|Adds %{commitCount} to %{targetBranch}.') + ? s__('mrWidgetCommitsAdded|%{commitCount} will be added to %{targetBranch}.') : s__( - 'mrWidgetCommitsAdded|Adds %{commitCount} and %{mergeCommitCount} to %{targetBranch}%{squashedCommits}.', + 'mrWidgetCommitsAdded|%{commitCount} and %{mergeCommitCount} will be added to %{targetBranch}%{squashedCommits}.', ); }, - textDecorativeComponent() { - return this.glFeatures.restructuredMrWidget ? 'span' : 'strong'; - }, squashCommitMessage() { if (this.isMerged) { return s__('mergedCommitsAdded|(commits were squashed)'); @@ -93,25 +82,19 @@ export default { + + diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_related_links.vue b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_related_links.vue index 913aa0e1e34..94a1b805b99 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_related_links.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_related_links.vue @@ -1,7 +1,6 @@ diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.vue b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.vue index 7ff1eb6e73a..5b8acb4ebf8 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_status_icon.vue @@ -1,25 +1,17 @@ diff --git a/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_checking.vue b/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_checking.vue index fd42fa0421f..e2d87d8d536 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_checking.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_checking.vue @@ -1,5 +1,4 @@